From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MsgZz-0001sq-91
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 13:33:35 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MsgZu-0001mw-GY
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 13:33:34 -0400
Received: from [199.232.76.173] (port=50291 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MsgZu-0001mj-AY
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 13:33:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58263)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1MsgZr-0000wE-L6
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 13:33:28 -0400
Date: Tue, 29 Sep 2009 19:31:24 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20090929173124.GB14384@redhat.com>
References: <4AB9AA8E.7060800@third-harmonic.com> <4AC1A49A.1010308@redhat.com>
	<20090929065856.GC25389@redhat.com> <4AC1B5CD.7050702@redhat.com>
	<20090929085450.GE25389@redhat.com>
	<4AC211C8.1060202@codemonkey.ws>
	<20090929140601.GA28733@redhat.com>
	<4AC21660.6020304@codemonkey.ws>
	<20090929163039.GA14044@redhat.com> <4AC24335.80505@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4AC24335.80505@codemonkey.ws>
Subject: [Qemu-devel] Re: [PATCH 0/2] fix virtio_blk serial pci config
	breakage
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: john cooper <john.cooper@third-harmonic.com>, john cooper <john.cooper@redhat.com>, Rusty Russell <rusty@rustcorp.com.au>, qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>, jens.axboe@oracle.com, Vadim Rozenfeld <vrozenfe@redhat.com>

On Tue, Sep 29, 2009 at 12:26:13PM -0500, Anthony Liguori wrote:
> Michael S. Tsirkin wrote:
>> On Tue, Sep 29, 2009 at 09:14:56AM -0500, Anthony Liguori wrote:
>>   
>>> Michael S. Tsirkin wrote:
>>>     
>>>> I don't think it's such a good idea.  We want to keep exposing most of
>>>> config space in i/o bar because of backwards compatibility.  And we want
>>>> to keep datapath operations such as vq kicks, in i/o space.
>>>>         
>>> We can do feature negotiation in virtio-pci.  That lets us continue   
>>> exposing the first 246 bytes of the config space in PIO and guests 
>>> can  negotiate a second bar for access to larger config spaces.
>>>
>>> Regards,
>>>
>>> Anthony Liguori
>>>     
>>
>> guests can't negotiate a bar.
>>   
>
> The host always exposes the config in two places.  config[0..235] in  
> bytes 20-255 in BAR0 and the full config space in BAR2 (or BAR1 + offset  
> if desired).  Old drivers will just ignore the new config location.
>
>> What I think we want to do
>> - Use i/o for small fields (2-4 bytes) as we did previously
>>   we won't run out anytime soon
>> - For large fields, put them in memory BAR1 and report the
>>   offset in i/o space
>>   
>
> This is at best a band aid as a large number of small fields can result  
> in the same problem.

It would have to be very large :)

>> - For huge fields, provide a mailbox in i/o space where guest
>>   writes an offset and reads out a value
>>   
>
> Regards,
>
> Anthony Liguori