From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MsgV2-0003gG-Ko
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 13:28:28 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MsgUx-0003cs-Qb
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 13:28:28 -0400
Received: from [199.232.76.173] (port=55258 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MsgUx-0003ci-BW
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 13:28:23 -0400
Received: from ozlabs.org ([203.10.76.45]:41590)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <rusty@rustcorp.com.au>) id 1MsgUw-00007a-Fm
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 13:28:23 -0400
From: Rusty Russell <rusty@rustcorp.com.au>
Date: Wed, 30 Sep 2009 02:58:16 +0930
References: <4AB7A01A.3000206@redhat.com> <20090929085450.GE25389@redhat.com>
	<4AC211C8.1060202@codemonkey.ws>
In-Reply-To: <4AC211C8.1060202@codemonkey.ws>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200909300258.17297.rusty@rustcorp.com.au>
Subject: [Qemu-devel] Re: [PATCH 0/2] fix virtio_blk serial pci config
	breakage
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: john cooper <john.cooper@third-harmonic.com>, "Michael S. Tsirkin" <mst@redhat.com>, john cooper <john.cooper@redhat.com>, qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>, jens.axboe@oracle.com, Vadim Rozenfeld <vrozenfe@redhat.com>

On Tue, 29 Sep 2009 11:25:20 pm Anthony Liguori wrote:
> 2) Passing an ATA identity page is goofy.  We should just pass the 
> serial number and let Linux generate the identity page.  Just because 
> Linux requires this as it's user space interface, that doesn't mean that 
> other guests will (like Windows).  Instead of exposing an opaque blob, 
> we should expose the information we need in a structured way.

I think John did this on my prompting, because it already existed as a
defined ABI.  If someone is going to make stuff up, isn't it better that
kvm does it (some of those fields might have useful values?) than linux?

(I don't care: my patches stick with the current scheme, but changing is
fairly easy, but needs to be decided before commit).

Thanks,
Rusty,