From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Msxqw-0005p2-8B for qemu-devel@nongnu.org; Wed, 30 Sep 2009 08:00:14 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Msxqr-0005nK-4b for qemu-devel@nongnu.org; Wed, 30 Sep 2009 08:00:13 -0400 Received: from [199.232.76.173] (port=49669 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Msxqq-0005n7-UY for qemu-devel@nongnu.org; Wed, 30 Sep 2009 08:00:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25798) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Msxqq-0002qY-Dr for qemu-devel@nongnu.org; Wed, 30 Sep 2009 08:00:08 -0400 Date: Wed, 30 Sep 2009 13:58:09 +0200 From: "Michael S. Tsirkin" Subject: Re: [Qemu-devel] [PATCH 2/9] pci.c: use appropriate PRIs in PCI_DPRINTF(). Message-ID: <20090930115809.GN18802@redhat.com> References: <1247656509-32227-1-git-send-email-yamahata@valinux.co.jp> <1247656509-32227-3-git-send-email-yamahata@valinux.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1247656509-32227-3-git-send-email-yamahata@valinux.co.jp> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: qemu-devel@nongnu.org On Wed, Jul 15, 2009 at 08:15:02PM +0900, Isaku Yamahata wrote: > use appropriate PRIs in PCI_DPRINTF() for portability. > > Signed-off-by: Isaku Yamahata Wait a second. So how about we really switch to pcibus_t, and do typedef unsigned long long pcibus_t Now we can use a clean and portable "%llx" to print it instead of the ugly PRIs. > --- > hw/pci.c | 10 ++++++---- > 1 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/hw/pci.c b/hw/pci.c > index 2963da2..916938a 100644 > --- a/hw/pci.c > +++ b/hw/pci.c > @@ -564,7 +564,7 @@ void pci_data_write(void *opaque, uint32_t addr, uint32_t val, int len) > int config_addr, bus_num; > > #if 0 > - PCI_DPRINTF("pci_data_write: addr=%08x val=%08x len=%d\n", > + PCI_DPRINTF("pci_data_write: addr=%08"PRIx32" val=%08"PRIx32" len=%d\n", > addr, val, len); > #endif > bus_num = (addr >> 16) & 0xff; > @@ -576,7 +576,8 @@ void pci_data_write(void *opaque, uint32_t addr, uint32_t val, int len) > if (!pci_dev) > return; > config_addr = addr & 0xff; > - PCI_DPRINTF("pci_config_write: %s: addr=%02x val=%08x len=%d\n", > + PCI_DPRINTF("pci_config_write: %s: " > + "addr=%02"PRIx32" val=%08"PRI32x" len=%d\n", > pci_dev->name, config_addr, val, len); > pci_dev->config_write(pci_dev, config_addr, val, len); > } > @@ -612,11 +613,12 @@ uint32_t pci_data_read(void *opaque, uint32_t addr, int len) > } > config_addr = addr & 0xff; > val = pci_dev->config_read(pci_dev, config_addr, len); > - PCI_DPRINTF("pci_config_read: %s: addr=%02x val=%08x len=%d\n", > + PCI_DPRINTF("pci_config_read: %s: " > + "addr=%02"PRIx32" val=%08"PRIx32" len=%d\n", > pci_dev->name, config_addr, val, len); > the_end: > #if 0 > - PCI_DPRINTF("pci_data_read: addr=%08x val=%08x len=%d\n", > + PCI_DPRINTF("pci_data_read: addr=%08"PRIx32" val=%08"PRIx32" len=%d\n", > addr, val, len); > #endif > return val; > -- > 1.6.0.2 > >