From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Msxf3-0006OL-Sm
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 07:47:57 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Msxey-0006KF-SA
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 07:47:57 -0400
Received: from [199.232.76.173] (port=47750 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Msxey-0006K8-IT
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 07:47:52 -0400
Received: from mx20.gnu.org ([199.232.41.8]:31194)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1Msxey-0001Cz-4K
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 07:47:52 -0400
Received: from [65.74.133.4] (helo=mail.codesourcery.com)
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1Msxew-0003DG-3a
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 07:47:50 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] Re: [PATCH 0/2] fix virtio_blk serial pci config
	breakage
Date: Wed, 30 Sep 2009 12:47:46 +0100
References: <4AB7A01A.3000206@redhat.com> <4AC25599.1090400@third-harmonic.com>
	<4AC2744B.1080601@codemonkey.ws>
In-Reply-To: <4AC2744B.1080601@codemonkey.ws>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200909301247.46394.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: john cooper <john.cooper@third-harmonic.com>, "Michael S. Tsirkin" <mst@redhat.com>, john cooper <john.cooper@redhat.com>, Rusty Russell <rusty@rustcorp.com.au>, Avi Kivity <avi@redhat.com>, jens.axboe@oracle.com, Vadim Rozenfeld <vrozenfe@redhat.com>

> > But the rationale that got us here was from the
> > user's perspective this information could be
> > trivially exposed via a preexisting interface vs.
> > creating a new interface as I'd done initially.
> > It was also pointed out other defined fields in
> > the identify page exist which were potentially
> > useful.  So pressing a HDIO_GET_IDENTITY ioctl
> > into service here didn't seem unreasonable.
> 
> virtio-blk isn't an ATA device so why pretend like it is?

Agreed. If we're going to copy anything than my vote would be for SCSI. We 
already have partial support for feeding SCSI commands to a virtio device.
TBH I wouldn't have bothered with virtio-blk at all, and gone straight for 
virtio-scsi. I guess it's a bit late for that though.

Paul