From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mszct-0007bR-AO
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 09:53:51 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mszcn-0007X1-NZ
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 09:53:49 -0400
Received: from [199.232.76.173] (port=46273 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mszcn-0007Wa-Gs
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 09:53:45 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57714)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1Mszcm-0006Fp-Mu
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 09:53:45 -0400
Date: Wed, 30 Sep 2009 15:51:42 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20090930135142.GA20378@redhat.com>
References: <20090923200635.GA21246@redhat.com>
	<f43fc5580909241050jc8b82fbsb25eef096f8105eb@mail.gmail.com>
	<20090924191121.GB29419@redhat.com>
	<f43fc5580909241313s64f14688he6cdb23e2bc2edfb@mail.gmail.com>
	<20090929161115.GA13885@redhat.com>
	<f43fc5580909291115y4ac36d4bja3a9bb5937312e44@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <f43fc5580909291115y4ac36d4bja3a9bb5937312e44@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: CODING_STYLE (was Re: [PATCHv2] qemu: target
	library, use it in msix)
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org

On Tue, Sep 29, 2009 at 09:15:04PM +0300, Blue Swirl wrote:
> On Tue, Sep 29, 2009 at 7:11 PM, Michael S. Tsirkin <mst@redhat.com> wr=
ote:
> > On Thu, Sep 24, 2009 at 11:13:38PM +0300, Blue Swirl wrote:
> >> >> As this is not a clean revert anyway, please don't revert the par=
t changing
> >> >> if (x)
> >> >> =A0y;
> >> >> else
> >> >> =A0z;
> >> >>
> >> >> to
> >> >>
> >> >> if (x) {
> >> >> =A0y;
> >> >> } else {
> >> >> =A0z;
> >> >> }
> >> >
> >> > Did I mention I hate this style? But okay :).
> >>
> >> I'm not a great fan of this either, but this is the CODING_STYLE.
> >
> > Maybe we can all vote to change this?
>=20
> Actually, I tried to tweak 'indent' to match QEMU style without much su=
ccess.
>=20
> We could also select a new style, like Linux kernel one. I'm also not
> a great fan of that either. But at least 'indent' could be used very
> easily and I think there would be other benefits, like reuse of Git
> hooks, patch checking scripts and Emacs configs. With full 'indent'
> support all sources could be massaged mechanically to make the switch
> less painful.
>=20
> Then there are K&R and GNU styles, but I like them even less.

So ... Linux kernel style wins? What do others think?

--=20
MST