From: "Michael S. Tsirkin" <mst@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: CODING_STYLE (was Re: [PATCHv2] qemu: target library, use it in msix)
Date: Wed, 30 Sep 2009 19:29:11 +0200 [thread overview]
Message-ID: <20090930172911.GB28300@redhat.com> (raw)
In-Reply-To: <4AC38EA4.70700@redhat.com>
On Wed, Sep 30, 2009 at 07:00:20PM +0200, Avi Kivity wrote:
> On 09/30/2009 03:51 PM, Michael S. Tsirkin wrote:
>> So ... Linux kernel style wins? What do others think?
>>
>
>
> Any change is going to cause a large amount of pain if implemented.
First thing would be to start running checkpatch on submissions. This
way, we gradually convert. Current style does not have automated
checker, so new code constantly deviates from it.
> --
> error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-09-30 17:31 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-23 20:06 [Qemu-devel] [PATCHv2] qemu: target library, use it in msix Michael S. Tsirkin
2009-09-24 17:50 ` [Qemu-devel] " Blue Swirl
2009-09-24 19:11 ` Michael S. Tsirkin
2009-09-24 20:13 ` Blue Swirl
2009-09-29 16:11 ` [Qemu-devel] CODING_STYLE (was Re: [PATCHv2] qemu: target library, use it in msix) Michael S. Tsirkin
2009-09-29 18:15 ` [Qemu-devel] " Blue Swirl
2009-09-30 13:51 ` Michael S. Tsirkin
2009-09-30 16:50 ` malc
2009-09-30 17:00 ` Avi Kivity
2009-09-30 17:29 ` Michael S. Tsirkin [this message]
2009-09-30 17:29 ` Blue Swirl
2009-09-30 21:01 ` Anthony Liguori
2009-10-01 6:17 ` Michael S. Tsirkin
2009-10-01 8:43 ` Kevin Wolf
2009-10-01 8:58 ` Michael S. Tsirkin
2009-10-01 9:10 ` Kevin Wolf
2009-10-01 9:17 ` Michael S. Tsirkin
2009-10-01 6:31 ` Avi Kivity
2009-10-01 6:47 ` Michael S. Tsirkin
2009-10-01 7:08 ` Paolo Bonzini
2009-09-30 17:00 ` [Qemu-devel] Re: CODING_STYLE Juan Quintela
2009-10-01 1:25 ` Edgar E. Iglesias
2009-10-01 6:41 ` Michael S. Tsirkin
2009-10-01 9:01 ` Gleb Natapov
2009-10-01 8:56 ` Kevin Wolf
2009-10-01 9:02 ` Michael S. Tsirkin
2009-10-01 9:46 ` Gleb Natapov
2009-10-01 10:02 ` Michael S. Tsirkin
2009-10-01 9:01 ` Gleb Natapov
2009-09-30 17:02 ` Markus Armbruster
2009-10-01 6:37 ` Amit Shah
2009-09-30 17:31 ` [Qemu-devel] Re: CODING_STYLE (was Re: [PATCHv2] qemu: target library, use it in msix) Paolo Bonzini
2009-09-30 17:32 ` Michael S. Tsirkin
2009-09-30 17:48 ` Michael S. Tsirkin
2009-09-30 18:32 ` Paolo Bonzini
2009-10-01 6:00 ` Michael S. Tsirkin
2009-09-30 20:11 ` [Qemu-devel] Re: CODING_STYLE Markus Armbruster
2009-09-30 21:00 ` [Qemu-devel] Re: CODING_STYLE (was Re: [PATCHv2] qemu: target library, use it in msix) Anthony Liguori
2009-09-30 23:01 ` [Qemu-devel] Re: CODING_STYLE Markus Armbruster
2009-09-30 23:24 ` Anthony Liguori
2009-09-30 16:06 ` [Qemu-devel] Re: CODING_STYLE (was Re: [PATCHv2] qemu: target library, use it in msix) Christoph Hellwig
2009-09-30 16:14 ` Michael S. Tsirkin
2009-09-30 21:04 ` Anthony Liguori
2009-09-27 8:20 ` [Qemu-devel] Re: [PATCHv2] qemu: target library, use it in msix Michael S. Tsirkin
2009-09-27 10:40 ` Avi Kivity
2009-09-27 11:45 ` Michael S. Tsirkin
2009-09-27 11:55 ` Avi Kivity
2009-09-27 12:00 ` Michael S. Tsirkin
2009-09-27 12:19 ` Avi Kivity
2009-09-27 14:08 ` Michael S. Tsirkin
2009-09-27 14:14 ` Avi Kivity
2009-09-27 14:21 ` Michael S. Tsirkin
2009-09-27 14:24 ` Michael S. Tsirkin
2009-09-27 15:19 ` Blue Swirl
2009-09-29 14:50 ` Michael S. Tsirkin
2009-09-29 15:15 ` Blue Swirl
2009-09-29 15:57 ` Michael S. Tsirkin
2009-09-29 16:26 ` Avi Kivity
2009-09-29 16:38 ` Michael S. Tsirkin
2009-09-29 19:34 ` Blue Swirl
2009-09-29 21:09 ` Michael S. Tsirkin
2009-09-27 14:26 ` Avi Kivity
2009-09-29 7:19 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090930172911.GB28300@redhat.com \
--to=mst@redhat.com \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).