From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mt31F-0001qh-Jq for qemu-devel@nongnu.org; Wed, 30 Sep 2009 13:31:13 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mt31B-0001kY-KA for qemu-devel@nongnu.org; Wed, 30 Sep 2009 13:31:13 -0400 Received: from [199.232.76.173] (port=60439 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mt31B-0001kH-4o for qemu-devel@nongnu.org; Wed, 30 Sep 2009 13:31:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1025) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mt31A-0002GS-L6 for qemu-devel@nongnu.org; Wed, 30 Sep 2009 13:31:08 -0400 Date: Wed, 30 Sep 2009 19:29:11 +0200 From: "Michael S. Tsirkin" Subject: Re: [Qemu-devel] Re: CODING_STYLE (was Re: [PATCHv2] qemu: target library, use it in msix) Message-ID: <20090930172911.GB28300@redhat.com> References: <20090923200635.GA21246@redhat.com> <20090924191121.GB29419@redhat.com> <20090929161115.GA13885@redhat.com> <20090930135142.GA20378@redhat.com> <4AC38EA4.70700@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AC38EA4.70700@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Blue Swirl , qemu-devel@nongnu.org On Wed, Sep 30, 2009 at 07:00:20PM +0200, Avi Kivity wrote: > On 09/30/2009 03:51 PM, Michael S. Tsirkin wrote: >> So ... Linux kernel style wins? What do others think? >> > > > Any change is going to cause a large amount of pain if implemented. First thing would be to start running checkpatch on submissions. This way, we gradually convert. Current style does not have automated checker, so new code constantly deviates from it. > -- > error compiling committee.c: too many arguments to function