From: Gleb Natapov <gleb@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Kevin O'Connor <kevin@koconnor.net>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH][SEABIOS] Move qemu config port access functions into separate file.
Date: Wed, 30 Sep 2009 19:31:56 +0200 [thread overview]
Message-ID: <20090930173156.GO9832@redhat.com> (raw)
In-Reply-To: <f43fc5580909301017j2f842b7fk63ff0452b3f83c09@mail.gmail.com>
On Wed, Sep 30, 2009 at 08:17:26PM +0300, Blue Swirl wrote:
> On Wed, Sep 30, 2009 at 9:35 AM, Gleb Natapov <gleb@redhat.com> wrote:
> > On Tue, Sep 29, 2009 at 09:09:46PM -0400, Kevin O'Connor wrote:
> >> On Sat, Sep 19, 2009 at 08:56:55PM +0300, Gleb Natapov wrote:
> >> > On Sat, Sep 19, 2009 at 11:16:41AM -0400, Kevin O'Connor wrote:
> >> > > Maybe a stream could be introduced with something like:
> >> > > <name><len><data> <name2><len2><data2> ...
> >> > >
> >> > The format is already set. The are two ports. You write option id in
> >> > first port and you read option value from second one. The value format
> >> > is different for each option. Additional acpi table format is like I
> >> > described above. If we want to use the same APIs for config access for
> >> > coreboot and qemu the API will have to be general enough to accommodate
> >> > both approaches. Changing formats is not an option at this stage.
> >>
> >> Okay - it doesn't sound like there is much overlap here between qemu
> >> and coreboot. On coreboot cbfs is used for pulling out option roms,
> >> executables, and floppy images - none of which have much use under
> >> qemu anyway.
> >>
> >> So, maybe we should just go back to the discussion of a config
> >> interface. I think it would be nice to have one api for getting
> >> config items for both qemu and coreboot - something like
> >> get_config_u32("ShowBootMenu"). On coreboot that info could then be
> >> extracted from cbfs and qemu can get in from the "cfg port".
> >>
> >> Does that make sense?
> >>
> > Yes. That is the direction I was going to take. Lest implement simple
> > name/value interface first and table loading code will be different.
> > If there will be much overlap in table loading code we will unify it
> > later.
>
> The name/value interface could be useful for OpenBIOS too if we want
> to avoid using NVRAM for OpenBIOS variables for compatibility. There
> should be methods to iterate through all keys and get the byte size of
> the value.
>
> For example, current fw_cfg interface could be extended to allow
> string keys in addition to integer keys.
There are two types of string keys. Those that you know the length in
advance (like uuid) and those you don't. fw_cfg can support second type
without additional change by passing <len><string> as a value. This will
be hidden from seabios behind get_config_string() interface of course.
--
Gleb.
next prev parent reply other threads:[~2009-09-30 17:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-14 12:51 [Qemu-devel] [PATCH][SEABIOS] Move qemu config port access functions into separate file Gleb Natapov
2009-09-15 0:08 ` [Qemu-devel] " Kevin O'Connor
2009-09-15 5:43 ` Gleb Natapov
2009-09-16 2:02 ` Kevin O'Connor
2009-09-17 9:57 ` Gleb Natapov
2009-09-18 1:24 ` Kevin O'Connor
2009-09-18 10:01 ` Gleb Natapov
2009-09-19 15:16 ` Kevin O'Connor
2009-09-19 17:56 ` Gleb Natapov
2009-09-30 1:09 ` Kevin O'Connor
2009-09-30 6:35 ` Gleb Natapov
2009-09-30 17:17 ` Blue Swirl
2009-09-30 17:31 ` Gleb Natapov [this message]
2009-10-02 1:08 ` Kevin O'Connor
2009-10-01 16:35 ` Gleb Natapov
2009-10-02 0:51 ` Kevin O'Connor
2009-10-02 14:03 ` Gleb Natapov
2009-10-02 16:52 ` Kevin O'Connor
2009-10-02 18:10 ` Gleb Natapov
2009-10-02 19:31 ` Kevin O'Connor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090930173156.GO9832@redhat.com \
--to=gleb@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=kevin@koconnor.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).