From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mt34n-0004S4-6Z
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 13:34:53 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mt34i-0004QA-SG
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 13:34:52 -0400
Received: from [199.232.76.173] (port=41002 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mt34i-0004Q5-5I
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 13:34:48 -0400
Date: Wed, 30 Sep 2009 19:32:45 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20090930173245.GA1305@redhat.com>
References: <20090923200635.GA21246@redhat.com>
	<f43fc5580909241050jc8b82fbsb25eef096f8105eb@mail.gmail.com>
	<20090924191121.GB29419@redhat.com>
	<f43fc5580909241313s64f14688he6cdb23e2bc2edfb@mail.gmail.com>
	<20090929161115.GA13885@redhat.com>
	<f43fc5580909291115y4ac36d4bja3a9bb5937312e44@mail.gmail.com>
	<20090930135142.GA20378@redhat.com> <4AC395F8.8030004@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4AC395F8.8030004@gnu.org>
Subject: [Qemu-devel] Re: CODING_STYLE (was Re: [PATCHv2] qemu: target
	library, use it in msix)
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <bonzini@gnu.org>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org

On Wed, Sep 30, 2009 at 07:31:36PM +0200, Paolo Bonzini wrote:
>
>>> We could also select a new style, like Linux kernel one. I'm also not
>>> a great fan of that either. But at least 'indent' could be used very
>>> easily and I think there would be other benefits, like reuse of Git
>>> hooks, patch checking scripts and Emacs configs. With full 'indent'
>>> support all sources could be massaged mechanically to make the switch
>>> less painful.
>>>
>>> Then there are K&R and GNU styles, but I like them even less.
>>
>> So ... Linux kernel style wins? What do others think?
>
> Linux kernel with 4-char indent?  That would avoid the need to run  
> indent

That loses the benefit of automatic style checkers/formatters
developed for kernel.

> (indent requires knowledge of all the names of the types, so a  
> mechanical pass through the sources is more easily said than done).
>
> Paolo

vim does a decent job typically.


-- 
MST