From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MtDj1-0007Hj-1b for qemu-devel@nongnu.org; Thu, 01 Oct 2009 00:57:07 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MtDiw-0007H5-29 for qemu-devel@nongnu.org; Thu, 01 Oct 2009 00:57:06 -0400 Received: from [199.232.76.173] (port=34513 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MtDiv-0007H2-Qh for qemu-devel@nongnu.org; Thu, 01 Oct 2009 00:57:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39535) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MtDiv-0005BH-5b for qemu-devel@nongnu.org; Thu, 01 Oct 2009 00:57:01 -0400 Date: Thu, 1 Oct 2009 10:26:22 +0530 From: Amit Shah Subject: Re: [Qemu-devel] [PATCH 1/6] char: Emit 'OPENED' events on char device open Message-ID: <20091001045622.GB18563@amit-x200.redhat.com> References: <1254225888-17093-1-git-send-email-amit.shah@redhat.com> <1254225888-17093-2-git-send-email-amit.shah@redhat.com> <4AC3C9FD.3050705@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AC3C9FD.3050705@codemonkey.ws> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org On (Wed) Sep 30 2009 [16:13:33], Anthony Liguori wrote: > Amit Shah wrote: >> Notify users of the char interface whenever the file / connection is >> opened. >> >> The existing RESET event is triggered when the qemu char state is reset >> as well; which may not be as interesting as char device open events. >> >> Signed-off-by: Amit Shah >> > > This series breaks the build (ppc440_bamboo.c). This patch or this series? If it's this patch, that's surprising! > You should always build without an explicit --target-list to avoid this > in the future. Sure -- I intend to when I send a request for the merging once all the comments have been sorted out. Thanks, Amit