qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 2/2] hw/omap_dma: add matching {} in if 0
Date: Thu, 1 Oct 2009 07:51:44 +0200	[thread overview]
Message-ID: <20091001055144.GC5068@redhat.com> (raw)
In-Reply-To: <cover.1254376223.git.mst@redhat.com>

MULTI_REQ is never defined, so it doesn't matter much, but since we have
an if statement there, let's add {} to clarify what it should do if it's
uncommented.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 hw/omap_dma.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/hw/omap_dma.c b/hw/omap_dma.c
index 205d010..ab5e925 100644
--- a/hw/omap_dma.c
+++ b/hw/omap_dma.c
@@ -588,7 +588,7 @@ static void omap_dma_transfer_setup(struct soc_dma_ch_s *dma)
 #ifdef MULTI_REQ
     /* TODO: should all of this only be done if dma->update, and otherwise
      * inside omap_dma_transfer_generic below - check what's faster.  */
-    if (dma->update)
+    if (dma->update) {
 #endif
 
     /* If the channel is element synchronized, deactivate it */
@@ -670,6 +670,8 @@ static void omap_dma_transfer_setup(struct soc_dma_ch_s *dma)
          * bits on it.  */
 #ifndef MULTI_REQ
     }
+#else
+    }
 #endif
 
     omap_dma_interrupts_update(s);
-- 
1.6.5.rc2

  parent reply	other threads:[~2009-10-01  5:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1254376223.git.mst@redhat.com>
2009-10-01  5:51 ` [Qemu-devel] [PATCH 1/2] tests: missing ; in if 0 Michael S. Tsirkin
2009-10-01  5:51 ` Michael S. Tsirkin [this message]
2009-10-01 13:05   ` [Qemu-devel] [PATCH 2/2] hw/omap_dma: add matching {} " Markus Armbruster
2009-10-01 13:10     ` Michael S. Tsirkin
2009-10-01 14:05       ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091001055144.GC5068@redhat.com \
    --to=mst@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).