From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MtFJ7-00035l-0F
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 02:38:29 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MtFJ1-00032I-H0
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 02:38:28 -0400
Received: from [199.232.76.173] (port=59871 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MtFJ0-00031n-In
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 02:38:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:17284)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <amit.shah@redhat.com>) id 1MtFIz-0001Wj-HZ
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 02:38:22 -0400
Date: Thu, 1 Oct 2009 12:07:43 +0530
From: Amit Shah <amit.shah@redhat.com>
Subject: Re: [Qemu-devel] Re: CODING_STYLE
Message-ID: <20091001063743.GC18563@amit-x200.redhat.com>
References: <20090923200635.GA21246@redhat.com>
	<f43fc5580909241050jc8b82fbsb25eef096f8105eb@mail.gmail.com>
	<20090924191121.GB29419@redhat.com>
	<f43fc5580909241313s64f14688he6cdb23e2bc2edfb@mail.gmail.com>
	<20090929161115.GA13885@redhat.com>
	<f43fc5580909291115y4ac36d4bja3a9bb5937312e44@mail.gmail.com>
	<20090930135142.GA20378@redhat.com>
	<87y6nwfjse.fsf@pike.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87y6nwfjse.fsf@pike.pond.sub.org>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>

On (Wed) Sep 30 2009 [19:02:09], Markus Armbruster wrote:
> > So ... Linux kernel style wins? What do others think?
> 
> I find certain aspects of QEMU style rather distasteful, too.  Linux
> kernel style is okay.  It can push deeply indented code far to the right
> and over the cliff, though.

The point it is that way is that if your code is indented so much that
it overflows, things are better rearranged in separate functions.

There are many such examples in qemu where splitting things off in
separate functions would make the code a lot more readable (and
maintainable).

		Amit