From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MtFLH-0003vx-8s for qemu-devel@nongnu.org; Thu, 01 Oct 2009 02:40:43 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MtFLC-0003uQ-Cx for qemu-devel@nongnu.org; Thu, 01 Oct 2009 02:40:42 -0400 Received: from [199.232.76.173] (port=59913 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MtFLC-0003uG-5r for qemu-devel@nongnu.org; Thu, 01 Oct 2009 02:40:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24906) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MtFLB-0001sQ-CP for qemu-devel@nongnu.org; Thu, 01 Oct 2009 02:40:37 -0400 Date: Thu, 1 Oct 2009 08:38:36 +0200 From: "Michael S. Tsirkin" Message-ID: <20091001063836.GA5663@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [Qemu-devel] [PATCH] linux-user: fix up oversealous nitpicking List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Laurent Desnogues , qemu-devel@nongnu.org Looks like linux-user code was correct, just unreadable: what it wanted to do with "-=" was really assign a negative number, not decrement. Fix up accordingly. Reported-by: Laurent Desnogues Signed-off-by: Michael S. Tsirkin --- linux-user/arm/nwfpe/fpa11.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/linux-user/arm/nwfpe/fpa11.c b/linux-user/arm/nwfpe/fpa11.c index c4461e0..17a6048 100644 --- a/linux-user/arm/nwfpe/fpa11.c +++ b/linux-user/arm/nwfpe/fpa11.c @@ -191,7 +191,7 @@ unsigned int EmulateAll(unsigned int opcode, FPA11* qfpa, CPUARMState* qregs) if(nRc == 1 && get_float_exception_flags(&fpa11->fp_status)) { //printf("fef 0x%x\n",float_exception_flags); - nRc -= get_float_exception_flags(&fpa11->fp_status); + nRc = -get_float_exception_flags(&fpa11->fp_status); } //printf("returning %d\n",nRc); -- 1.6.5.rc2