From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MtFU6-0006b9-Hq
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 02:49:50 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MtFU2-0006Zv-2C
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 02:49:50 -0400
Received: from [199.232.76.173] (port=51026 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MtFU1-0006Zs-VX
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 02:49:45 -0400
Received: from mx20.gnu.org ([199.232.41.8]:24802)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <mst@redhat.com>) id 1MtFU1-00031O-8z
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 02:49:45 -0400
Received: from mx1.redhat.com ([209.132.183.28])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1MtFU0-0003j3-I8
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 02:49:44 -0400
Date: Thu, 1 Oct 2009 08:47:46 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] Re: CODING_STYLE (was Re: [PATCHv2] qemu: target
	library, use it in msix)
Message-ID: <20091001064745.GA5687@redhat.com>
References: <20090923200635.GA21246@redhat.com>
	<f43fc5580909241050jc8b82fbsb25eef096f8105eb@mail.gmail.com>
	<20090924191121.GB29419@redhat.com>
	<f43fc5580909241313s64f14688he6cdb23e2bc2edfb@mail.gmail.com>
	<20090929161115.GA13885@redhat.com>
	<f43fc5580909291115y4ac36d4bja3a9bb5937312e44@mail.gmail.com>
	<20090930135142.GA20378@redhat.com> <4AC38EA4.70700@redhat.com>
	<f43fc5580909301029u1b777f9fhb114cf3e313f671b@mail.gmail.com>
	<4AC44CB4.8060006@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4AC44CB4.8060006@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org

On Thu, Oct 01, 2009 at 08:31:16AM +0200, Avi Kivity wrote:
> On 09/30/2009 07:29 PM, Blue Swirl wrote:
>> On Wed, Sep 30, 2009 at 8:00 PM, Avi Kivity<avi@redhat.com>  wrote:
>>    
>>> On 09/30/2009 03:51 PM, Michael S. Tsirkin wrote:
>>>      
>>>> So ... Linux kernel style wins? What do others think?
>>>>
>>>>        
>>>
>>> Any change is going to cause a large amount of pain if implemented.
>>>      
>> True, but with 'indent' support the pain would be brief.
>>    
>
> External trees (qemu-kvm, the Xen tree, distros which carry patches)  
> will all have to adapt, just so that we can reach 80 columns twice as  
> quickly.

Can external trees just run indent themselves before merging upstream?

> -- 
> Do not meddle in the internals of kernels, for they are subtle and quick to panic.