From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MtHWy-0001kF-HZ for qemu-devel@nongnu.org; Thu, 01 Oct 2009 05:00:56 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MtHWt-0001iI-P0 for qemu-devel@nongnu.org; Thu, 01 Oct 2009 05:00:56 -0400 Received: from [199.232.76.173] (port=38844 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MtHWt-0001iA-JK for qemu-devel@nongnu.org; Thu, 01 Oct 2009 05:00:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12769) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MtHWs-0007hK-TH for qemu-devel@nongnu.org; Thu, 01 Oct 2009 05:00:51 -0400 Date: Thu, 1 Oct 2009 10:58:48 +0200 From: "Michael S. Tsirkin" Subject: Re: [Qemu-devel] Re: CODING_STYLE (was Re: [PATCHv2] qemu: target library, use it in msix) Message-ID: <20091001085848.GC5718@redhat.com> References: <20090924191121.GB29419@redhat.com> <20090929161115.GA13885@redhat.com> <20090930135142.GA20378@redhat.com> <4AC38EA4.70700@redhat.com> <4AC3C70C.4020002@codemonkey.ws> <20091001061721.GC5142@redhat.com> <4AC46BA4.1090503@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AC46BA4.1090503@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Blue Swirl , Avi Kivity , qemu-devel@nongnu.org On Thu, Oct 01, 2009 at 10:43:16AM +0200, Kevin Wolf wrote: > Am 01.10.2009 08:17, schrieb Michael S. Tsirkin: > > On Wed, Sep 30, 2009 at 04:01:00PM -0500, Anthony Liguori wrote: > >> Blue Swirl wrote: > >>> On Wed, Sep 30, 2009 at 8:00 PM, Avi Kivity wrote: > >>> > >>>> On 09/30/2009 03:51 PM, Michael S. Tsirkin wrote: > >>>> > >>>>> So ... Linux kernel style wins? What do others think? > >>>>> > >>>>> > >>>> Any change is going to cause a large amount of pain if implemented. > >>>> > >>> > >>> True, but with 'indent' support the pain would be brief. > >>> > >> > >> It's equivalent to losing a massive amount of revision history which > >> hurts debugging. > > > > It is? Why is it? git bisect still works. what else do you use > > for debugging that gets broken? > > git blame. > > Kevin I think git blame has "-w" flag to ignore whitespace changes.