From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MtHY4-0002O1-54
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 05:02:04 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MtHXy-0002LC-PL
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 05:02:03 -0400
Received: from [199.232.76.173] (port=41614 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MtHXy-0002Kv-Gg
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 05:01:58 -0400
Received: from mx1.redhat.com ([209.132.183.28]:5591)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@redhat.com>) id 1MtHXx-0007uM-R5
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 05:01:58 -0400
Date: Thu, 1 Oct 2009 11:01:50 +0200
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] Re: CODING_STYLE
Message-ID: <20091001090150.GQ9832@redhat.com>
References: <20090923200635.GA21246@redhat.com>
	<f43fc5580909241050jc8b82fbsb25eef096f8105eb@mail.gmail.com>
	<20090924191121.GB29419@redhat.com>
	<f43fc5580909241313s64f14688he6cdb23e2bc2edfb@mail.gmail.com>
	<20090929161115.GA13885@redhat.com>
	<f43fc5580909291115y4ac36d4bja3a9bb5937312e44@mail.gmail.com>
	<20090930135142.GA20378@redhat.com> <m3y6nwnza2.fsf@neno.mitica>
	<20091001012548.GA26280@laped.iglesias.mooo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20091001012548.GA26280@laped.iglesias.mooo.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>

On Thu, Oct 01, 2009 at 03:25:48AM +0200, Edgar E. Iglesias wrote:
> On Wed, Sep 30, 2009 at 07:00:21PM +0200, Juan Quintela wrote:
> > "Michael S. Tsirkin" <mst@redhat.com> wrote:
> > 
> > ....
> > 
> > >> Actually, I tried to tweak 'indent' to match QEMU style without much success.
> > >> 
> > >> We could also select a new style, like Linux kernel one. I'm also not
> > >> a great fan of that either. But at least 'indent' could be used very
> > >> easily and I think there would be other benefits, like reuse of Git
> > >> hooks, patch checking scripts and Emacs configs. With full 'indent'
> > >> support all sources could be massaged mechanically to make the switch
> > >> less painful.
> > >> 
> > >> Then there are K&R and GNU styles, but I like them even less.
> > >
> > > So ... Linux kernel style wins? What do others think?
> > 
> > Where do I have to sign?
> 
> 	Yeah.
> 
> I really don't care very much. I've changed my CRIS and MicroBlaze code from
> style to style a couple of times but the only style regardless of style I find
> offensive is the:
> 
> if (x) {
>   x=1;
> } else {
>   x=0;
> }
> 
> TBH, the extra curley braceys are just pure nonsense.
> 
> 
> Remove those and I'm happy with tab or 2 or 4 or 8 or whatever amount of
> indentation spaces.

This is me to thread, so:
+1

--
			Gleb.