From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MtHpF-0001ji-Fb for qemu-devel@nongnu.org; Thu, 01 Oct 2009 05:19:49 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MtHpA-0001h5-Cp for qemu-devel@nongnu.org; Thu, 01 Oct 2009 05:19:48 -0400 Received: from [199.232.76.173] (port=46212 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MtHpA-0001h2-6T for qemu-devel@nongnu.org; Thu, 01 Oct 2009 05:19:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3699) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MtHp9-0002PK-Lt for qemu-devel@nongnu.org; Thu, 01 Oct 2009 05:19:44 -0400 Date: Thu, 1 Oct 2009 11:17:41 +0200 From: "Michael S. Tsirkin" Subject: Re: [Qemu-devel] Re: CODING_STYLE (was Re: [PATCHv2] qemu: target library, use it in msix) Message-ID: <20091001091741.GF5718@redhat.com> References: <20090929161115.GA13885@redhat.com> <20090930135142.GA20378@redhat.com> <4AC38EA4.70700@redhat.com> <4AC3C70C.4020002@codemonkey.ws> <20091001061721.GC5142@redhat.com> <4AC46BA4.1090503@redhat.com> <20091001085848.GC5718@redhat.com> <4AC471F4.4030308@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AC471F4.4030308@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Blue Swirl , Avi Kivity , qemu-devel@nongnu.org On Thu, Oct 01, 2009 at 11:10:12AM +0200, Kevin Wolf wrote: > Am 01.10.2009 10:58, schrieb Michael S. Tsirkin: > > On Thu, Oct 01, 2009 at 10:43:16AM +0200, Kevin Wolf wrote: > >> Am 01.10.2009 08:17, schrieb Michael S. Tsirkin: > >>> On Wed, Sep 30, 2009 at 04:01:00PM -0500, Anthony Liguori wrote: > >>>> Blue Swirl wrote: > >>>>> On Wed, Sep 30, 2009 at 8:00 PM, Avi Kivity wrote: > >>>>> > >>>>>> On 09/30/2009 03:51 PM, Michael S. Tsirkin wrote: > >>>>>> > >>>>>>> So ... Linux kernel style wins? What do others think? > >>>>>>> > >>>>>>> > >>>>>> Any change is going to cause a large amount of pain if implemented. > >>>>>> > >>>>> > >>>>> True, but with 'indent' support the pain would be brief. > >>>>> > >>>> > >>>> It's equivalent to losing a massive amount of revision history which > >>>> hurts debugging. > >>> > >>> It is? Why is it? git bisect still works. what else do you use > >>> for debugging that gets broken? > >> > >> git blame. > >> > >> Kevin > > > > I think git blame has "-w" flag to ignore whitespace changes. > > Are we only talking about changing the indentation? Switching from 4 > spaces to tabs of 8 characters also means additional line breaks and so > on (or does it handle these, too?). And I thought I read in this thread > about braces, typedefs and probably some more things. Can -w really > handle all of them? > > Kevin No. But if a line is very long, any code refactoring will create the same effect. Most lines arent that long. -- MST