From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MtLSm-0002iz-UX
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 09:12:53 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MtLSi-0002iN-0l
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 09:12:52 -0400
Received: from [199.232.76.173] (port=44934 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MtLSh-0002iK-PR
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 09:12:47 -0400
Received: from mx1.redhat.com ([209.132.183.28]:8936)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1MtLSh-0003KO-KB
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 09:12:47 -0400
Date: Thu, 1 Oct 2009 15:10:48 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] hw/omap_dma: add matching {} in if 0
Message-ID: <20091001131048.GA9820@redhat.com>
References: <cover.1254376223.git.mst@redhat.com>
	<20091001055144.GC5068@redhat.com>
	<87pr976z82.fsf@pike.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87pr976z82.fsf@pike.pond.sub.org>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org

On Thu, Oct 01, 2009 at 03:05:49PM +0200, Markus Armbruster wrote:
> "Michael S. Tsirkin" <mst@redhat.com> writes:
> 
> > MULTI_REQ is never defined, so it doesn't matter much, but since we have
> > an if statement there, let's add {} to clarify what it should do if it's
> > uncommented.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >  hw/omap_dma.c |    4 +++-
> >  1 files changed, 3 insertions(+), 1 deletions(-)
> >
> > diff --git a/hw/omap_dma.c b/hw/omap_dma.c
> > index 205d010..ab5e925 100644
> > --- a/hw/omap_dma.c
> > +++ b/hw/omap_dma.c
> > @@ -588,7 +588,7 @@ static void omap_dma_transfer_setup(struct soc_dma_ch_s *dma)
> >  #ifdef MULTI_REQ
> >      /* TODO: should all of this only be done if dma->update, and otherwise
> >       * inside omap_dma_transfer_generic below - check what's faster.  */
> > -    if (dma->update)
> > +    if (dma->update) {
> >  #endif
> >  
> >      /* If the channel is element synchronized, deactivate it */
> > @@ -670,6 +670,8 @@ static void omap_dma_transfer_setup(struct soc_dma_ch_s *dma)
> >           * bits on it.  */
> >  #ifndef MULTI_REQ
> >      }
> > +#else
> > +    }
> >  #endif
> >  
> >      omap_dma_interrupts_update(s);
> 
> Doesn't this look silly?  Just close the brace :)

This way we get more {'s than }'s, which is even more ugly.
We probably should indent the text within if (dma->update) though.

-- 
MST