From: Christoph Hellwig <hch@lst.de>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] block/raw: Add create_options for host_device
Date: Thu, 1 Oct 2009 19:13:53 +0200 [thread overview]
Message-ID: <20091001171353.GA19616@lst.de> (raw)
In-Reply-To: <1254393349-7557-1-git-send-email-kwolf@redhat.com>
On Thu, Oct 01, 2009 at 12:35:49PM +0200, Kevin Wolf wrote:
> Today host_devices have a create function, so they also need a create_options
> field to prevent qemu-img from complaining.
Yeah. But looking deeper does the size argument actually make any
sense for the host devices? What we do right now is to seek to the
total_size * 512 as some sort of tests, but it's not actually in any
way encoded in the image, we'll always get the normal raw_getlength
return value when quering for the size later.
next prev parent reply other threads:[~2009-10-01 17:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-01 10:35 [Qemu-devel] [PATCH] block/raw: Add create_options for host_device Kevin Wolf
2009-10-01 17:13 ` Christoph Hellwig [this message]
2009-10-02 7:33 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091001171353.GA19616@lst.de \
--to=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).