From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MtPEB-0000t5-GN for qemu-devel@nongnu.org; Thu, 01 Oct 2009 13:14:03 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MtPE6-0000mE-Br for qemu-devel@nongnu.org; Thu, 01 Oct 2009 13:14:02 -0400 Received: from [199.232.76.173] (port=58048 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MtPE5-0000la-RT for qemu-devel@nongnu.org; Thu, 01 Oct 2009 13:13:57 -0400 Received: from verein.lst.de ([213.95.11.210]:47874) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1MtPE5-0006ct-Ag for qemu-devel@nongnu.org; Thu, 01 Oct 2009 13:13:57 -0400 Date: Thu, 1 Oct 2009 19:13:53 +0200 From: Christoph Hellwig Subject: Re: [Qemu-devel] [PATCH] block/raw: Add create_options for host_device Message-ID: <20091001171353.GA19616@lst.de> References: <1254393349-7557-1-git-send-email-kwolf@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1254393349-7557-1-git-send-email-kwolf@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On Thu, Oct 01, 2009 at 12:35:49PM +0200, Kevin Wolf wrote: > Today host_devices have a create function, so they also need a create_options > field to prevent qemu-img from complaining. Yeah. But looking deeper does the size argument actually make any sense for the host devices? What we do right now is to seek to the total_size * 512 as some sort of tests, but it's not actually in any way encoded in the image, we'll always get the normal raw_getlength return value when quering for the size later.