From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MtT5W-0003s3-0L
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 17:21:22 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MtT5R-0003pp-GE
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 17:21:21 -0400
Received: from [199.232.76.173] (port=32896 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MtT5R-0003pg-A6
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 17:21:17 -0400
Received: from mx1.redhat.com ([209.132.183.28]:64279)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lcapitulino@redhat.com>) id 1MtT5Q-0002SS-TX
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 17:21:17 -0400
Date: Thu, 1 Oct 2009 18:21:08 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20091001182108.51a96a17@doriath>
In-Reply-To: <4AC4D250.3060903@redhat.com>
References: <1254412245-10452-1-git-send-email-lcapitulino@redhat.com>
	<4AC4D250.3060903@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v1 00/14]: Initial QObject conversion
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

On Thu, 01 Oct 2009 18:01:20 +0200
Avi Kivity <avi@redhat.com> wrote:

> On 10/01/2009 05:50 PM, Luiz Capitulino wrote:
> >   Hi there,
> >
> >   This series is an updated version of my initial QObject conversion series,
> > which adds the needed infrastructure to incrementally support new style
> > QObject handlers without breaking the current ones.
> >
> >   Some people have suggested that we should have a better error handling
> > in the Monitor, in the meaning that error information should be correctly
> > propagated and handled in order to be used by the Monitor Protocol and
> > the existing user protocol.
> >
> >   This series introduces the MonitorError data type to solve that problem,
> > it's used as part of the new infrastructure.
> >
> >   Additionally the following handlers are converted: do_quit(), do_stop(),
> > do_system_reset(), do_system_powerdown(), do_balloon(), do_info_version(),
> > do_info_balloon().
> >
> >   I've done a full build of QEMU with this series applied on Fedora 11 x86_64
> > and Debian Lenny i386, also tested manually all converted commands plus some
> > easy ones.
> >
> >   Please, review this carefully as some design decisions made here will
> > have impact in the Monitor Protocol.
> >
> >    
> 
> Looks good to me.
> 
> Regarding info, I think the machine protocol should manage it as 
> separate commands ("info-cpus" instead of "info"("cpus")).  Having a 
> function which returns wildly different return types (a string for 
> version, a device tree for qdev) is unwieldy.

 I agree and I think this approach would make my life easier.

 The problem though is how to properly refactor the code so that
we don't conflict with the user's 'info cpus' command.

 I will think about it, but would be good to decide this before
mass conversion.