From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MuNmk-0007sR-GM for qemu-devel@nongnu.org; Sun, 04 Oct 2009 05:53:46 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MuNmf-0007qq-CI for qemu-devel@nongnu.org; Sun, 04 Oct 2009 05:53:46 -0400 Received: from [199.232.76.173] (port=34510 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MuNmf-0007qi-5y for qemu-devel@nongnu.org; Sun, 04 Oct 2009 05:53:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3396) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MuNme-0008Po-4x for qemu-devel@nongnu.org; Sun, 04 Oct 2009 05:53:40 -0400 Date: Sun, 4 Oct 2009 11:51:36 +0200 From: "Michael S. Tsirkin" Message-ID: <20091004095136.GD16887@redhat.com> References: <1254514577-11896-1-git-send-email-yamahata@valinux.co.jp> <1254514577-11896-3-git-send-email-yamahata@valinux.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1254514577-11896-3-git-send-email-yamahata@valinux.co.jp> Subject: [Qemu-devel] Re: [PATCH 02/25] pci: use appropriate PRIs in PCI_DPRINTF() for portability. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: qemu-devel@nongnu.org On Sat, Oct 03, 2009 at 05:15:54AM +0900, Isaku Yamahata wrote: > use appropriate PRIs in PCI_DPRINTF() to print pci config space offset > and value for portability. > > Signed-off-by: Isaku Yamahata Can we just switch to "unsigned" here? There's no reason to force specific data width: in fact, address is probably a 16 bit value, and ISO types can be printed with plan printf without format macros. > --- > hw/pci.c | 10 ++++++---- > 1 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/hw/pci.c b/hw/pci.c > index 4392574..d281ee2 100644 > --- a/hw/pci.c > +++ b/hw/pci.c > @@ -561,7 +561,7 @@ void pci_data_write(void *opaque, uint32_t addr, uint32_t val, int len) > int config_addr, bus_num; > > #if 0 > - PCI_DPRINTF("pci_data_write: addr=%08x val=%08x len=%d\n", > + PCI_DPRINTF("pci_data_write: addr=%08"PRIx32" val=%08"PRIx32" len=%d\n", > addr, val, len); > #endif > bus_num = (addr >> 16) & 0xff; > @@ -573,7 +573,8 @@ void pci_data_write(void *opaque, uint32_t addr, uint32_t val, int len) > if (!pci_dev) > return; > config_addr = addr & 0xff; > - PCI_DPRINTF("pci_config_write: %s: addr=%02x val=%08x len=%d\n", > + PCI_DPRINTF("pci_config_write: %s: " > + "addr=%02x val=%08"PRI32x" len=%d\n", > pci_dev->name, config_addr, val, len); > pci_dev->config_write(pci_dev, config_addr, val, len); > } > @@ -609,11 +610,12 @@ uint32_t pci_data_read(void *opaque, uint32_t addr, int len) > } > config_addr = addr & 0xff; > val = pci_dev->config_read(pci_dev, config_addr, len); > - PCI_DPRINTF("pci_config_read: %s: addr=%02x val=%08x len=%d\n", > + PCI_DPRINTF("pci_config_read: %s: " > + "addr=%02x val=%08"PRIx32" len=%d\n", > pci_dev->name, config_addr, val, len); > the_end: > #if 0 > - PCI_DPRINTF("pci_data_read: addr=%08x val=%08x len=%d\n", > + PCI_DPRINTF("pci_data_read: addr=%08"PRIx32" val=%08"PRIx32" len=%d\n", > addr, val, len); > #endif > return val; > -- > 1.6.0.2 > >