From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MuO1I-00074o-GE
	for qemu-devel@nongnu.org; Sun, 04 Oct 2009 06:08:48 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MuO1E-00072t-SR
	for qemu-devel@nongnu.org; Sun, 04 Oct 2009 06:08:48 -0400
Received: from [199.232.76.173] (port=58332 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MuO1E-00072Z-Ia
	for qemu-devel@nongnu.org; Sun, 04 Oct 2009 06:08:44 -0400
Received: from mx1.redhat.com ([209.132.183.28]:1026)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1MuO1E-000251-2M
	for qemu-devel@nongnu.org; Sun, 04 Oct 2009 06:08:44 -0400
Date: Sun, 4 Oct 2009 12:06:41 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20091004100641.GL16887@redhat.com>
References: <1254514577-11896-1-git-send-email-yamahata@valinux.co.jp>
	<1254514577-11896-5-git-send-email-yamahata@valinux.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1254514577-11896-5-git-send-email-yamahata@valinux.co.jp>
Subject: [Qemu-devel] Re: [PATCH 04/25] pci: use the symbolic constant,
	PCI_ROM_ADDRESS_ENABLE instead of 1.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org

On Sat, Oct 03, 2009 at 05:15:56AM +0900, Isaku Yamahata wrote:
> use the symbolic constant, PCI_ROM_ADDRESS_ENABLE instead of 1.
> 
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>

Acked-by: Michael S. Tsirkin <mst@redhat.com>

> ---
>  hw/pci.c |    2 +-
>  hw/pci.h |    2 ++
>  2 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/pci.c b/hw/pci.c
> index 40035e6..1016893 100644
> --- a/hw/pci.c
> +++ b/hw/pci.c
> @@ -422,7 +422,7 @@ void pci_register_bar(PCIDevice *pci_dev, int region_num,
>      if (region_num == PCI_ROM_SLOT) {
>          addr = 0x30;
>          /* ROM enable bit is writeable */
> -        wmask |= 1;
> +        wmask |= PCI_ROM_ADDRESS_ENABLE;
>      } else {
>          addr = 0x10 + region_num * 4;
>      }
> diff --git a/hw/pci.h b/hw/pci.h
> index aa3090e..def45ae 100644
> --- a/hw/pci.h
> +++ b/hw/pci.h
> @@ -131,6 +131,8 @@ typedef struct PCIIORegion {
>  #define PCI_SUBVENDOR_ID        0x2c    /* obsolete, use PCI_SUBSYSTEM_VENDOR_ID */
>  #define PCI_SUBDEVICE_ID        0x2e    /* obsolete, use PCI_SUBSYSTEM_ID */
>  
> +#define  PCI_ROM_ADDRESS_ENABLE 0x01
> +

Please put this just after PCI_ROM_ADDRESS just like it appears in
pci_regs.h, to make it easier to find:

#define PCI_ROM_ADDRESS		0x30	/* Bits 31..11 are address, 10..1 reserved */
#define  PCI_ROM_ADDRESS_ENABLE	0x01

>  /* Bits in the PCI Status Register (PCI 2.3 spec) */
>  #define PCI_STATUS_RESERVED1	0x007
>  #define PCI_STATUS_INT_STATUS	0x008
> -- 
> 1.6.0.2
> 
>