From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MuQnj-0000Yq-EC
	for qemu-devel@nongnu.org; Sun, 04 Oct 2009 09:06:59 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MuQne-0000NG-O3
	for qemu-devel@nongnu.org; Sun, 04 Oct 2009 09:06:58 -0400
Received: from [199.232.76.173] (port=37447 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MuQne-0000N4-IT
	for qemu-devel@nongnu.org; Sun, 04 Oct 2009 09:06:54 -0400
Received: from mx1.redhat.com ([209.132.183.28]:13540)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@redhat.com>) id 1MuQne-0000e5-0v
	for qemu-devel@nongnu.org; Sun, 04 Oct 2009 09:06:54 -0400
Date: Sun, 4 Oct 2009 15:06:49 +0200
From: Gleb Natapov <gleb@redhat.com>
Message-ID: <20091004130649.GC9832@redhat.com>
References: <20091004090907.GW9832@redhat.com>
	<20091004130109.GA2472@morn.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20091004130109.GA2472@morn.localdomain>
Subject: [Qemu-devel] Re: [PATCH v2][SEABIOS] Move qemu config port access
 functions into separate file.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin O'Connor <kevin@koconnor.net>
Cc: qemu-devel@nongnu.org

On Sun, Oct 04, 2009 at 09:01:09AM -0400, Kevin O'Connor wrote:
> On Sun, Oct 04, 2009 at 11:09:07AM +0200, Gleb Natapov wrote:
> > 
> > Move qemu config code from smbios.c to its own files. Add support for
> > -boot menu=on|off qemu option.
> 
> Thanks Gleb.
> 
> Please rename the "pv" files - at a minimum to "paravirt", although I
> think "qemucfg" or "emucfg" is more appropriate.
> 
I want to put things like kvm_para_available() there too. qemucfg naming
suggest that this is only qemu fw_cfg driver, but I want it to be more.
I'll rename it to paravirt.[ch]

> The other thing is new ".c" files need a one line description and a
> copyright at the top.  If you don't care about the copyright then just
> reuse Fabrice's from smbios.c.
> 
> If you wish, I can make these changes.
> 
I'll resend.

--
			Gleb.