From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MuVmg-0001u9-Vd for qemu-devel@nongnu.org; Sun, 04 Oct 2009 14:26:15 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MuVmc-0001qB-4r for qemu-devel@nongnu.org; Sun, 04 Oct 2009 14:26:14 -0400 Received: from [199.232.76.173] (port=42731 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MuVmb-0001q5-VG for qemu-devel@nongnu.org; Sun, 04 Oct 2009 14:26:10 -0400 Received: from mtaout02-winn.ispmail.ntl.com ([81.103.221.48]:27263) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MuVmb-0007nF-Jo for qemu-devel@nongnu.org; Sun, 04 Oct 2009 14:26:09 -0400 Date: Sun, 4 Oct 2009 19:27:25 +0100 From: Stuart Brady Subject: Re: [Qemu-devel] [PATCH] tcg, tci: Add TCG and interpreter for bytecode (virtual machine) Message-ID: <20091004182724.GA26105@miranda.arrow> References: <4AC0E93A.6010605@mail.berlios.de> <1254156621-28559-1-git-send-email-weil@mail.berlios.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1254156621-28559-1-git-send-email-weil@mail.berlios.de> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil , qemu-devel@nongnu.org On Mon, Sep 28, 2009 at 06:50:21PM +0200, Stefan Weil wrote: > Please send patches / enhancements based on my latest > version from git://repo.or.cz/qemu/ar7.git. Just bug reports for now, unfortunately... exec-all.h defines 'USE_DIRECT_JUMP' based on the host architecture, which is not relevant under TCI. Also, a tb_set_jmp_target1() implementation is needed for TCI. I think tcg_out64() belongs in tcg.c along with tcg_out8/16/32(). There are places where the x86_64, ppc64 and s390 TCG targets call out32() twice, which should be replaced with a single call to out64(). tcg_out16(), tcg_out32() and tcg_out64(), etc. rely on the code buffer pointer being aligned on those architectures that require alignment... We'd need definitions of these in terms of stw_p(), stl_p() and stq_p() for TCI... Is there any reason to preserve the old definitions? (BTW, there's no 'ldul' macro, so perhaps one should be added, although the names in that set of macros and functions are rather unclear, so perhaps some more descriptive naming could be used for new code.) Cheers, -- Stuart Brady