From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mup3D-0007lP-2H for qemu-devel@nongnu.org; Mon, 05 Oct 2009 11:00:35 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mup37-0007eP-UH for qemu-devel@nongnu.org; Mon, 05 Oct 2009 11:00:34 -0400 Received: from [199.232.76.173] (port=44876 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mup37-0007eF-Pe for qemu-devel@nongnu.org; Mon, 05 Oct 2009 11:00:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34418) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mup37-0002xz-6p for qemu-devel@nongnu.org; Mon, 05 Oct 2009 11:00:29 -0400 Date: Mon, 5 Oct 2009 16:58:09 +0200 From: "Michael S. Tsirkin" Message-ID: <20091005145809.GA31473@redhat.com> References: <1254737223-16129-1-git-send-email-yamahata@valinux.co.jp> <1254737223-16129-22-git-send-email-yamahata@valinux.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1254737223-16129-22-git-send-email-yamahata@valinux.co.jp> Subject: [Qemu-devel] Re: [PATCH 21/23] pci/brdige: qdevfy and initialize secondary bus and subordinate bus. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: qemu-devel@nongnu.org On Mon, Oct 05, 2009 at 07:07:01PM +0900, Isaku Yamahata wrote: > + br = DO_UPCAST(PCIBridge, dev, d); By the way, why do we use DO_UPCAST thing, which requires that field is at the start of parent structure, instead of container_of which does not? -- MST