From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MuvxZ-0000bC-Jq for qemu-devel@nongnu.org; Mon, 05 Oct 2009 18:23:13 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MuvxX-0000Yo-Le for qemu-devel@nongnu.org; Mon, 05 Oct 2009 18:23:12 -0400 Received: from [199.232.76.173] (port=40204 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MuvxX-0000Yi-Gy for qemu-devel@nongnu.org; Mon, 05 Oct 2009 18:23:11 -0400 Received: from hall.aurel32.net ([88.191.82.174]:40201) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MuvxX-00041g-6i for qemu-devel@nongnu.org; Mon, 05 Oct 2009 18:23:11 -0400 Date: Mon, 5 Oct 2009 23:56:06 +0200 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH] i386 target: fix ARPL Message-ID: <20091005215606.GA22831@volta.aurel32.net> References: <761ea48b0910050818g6d3e9974h51a2d1d11fde5ee6@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <761ea48b0910050818g6d3e9974h51a2d1d11fde5ee6@mail.gmail.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Desnogues Cc: qemu-devel@nongnu.org On Mon, Oct 05, 2009 at 05:18:26PM +0200, Laurent Desnogues wrote: > Hello, > > The arpl implementation in target-i386/translate.c uses cpu_A0 > temporary across a brcond op. This patch fixes that issue. > > Note I didn't test it, I only looked at generated code to check it > was making sense. This looks indeed correct. I wonder however if it would be better to do the tcg_temp_local_new() / tcg_temp_free() in the if (mod != 3) path only. Also this patch needs a Signed-of-by: Aurelien > diff --git a/target-i386/translate.c b/target-i386/translate.c > index e3cb49f..807707f 100644 > --- a/target-i386/translate.c > +++ b/target-i386/translate.c > @@ -7305,13 +7305,14 @@ static target_ulong disas_insn(DisasContext *s, target_ulong pc_start) > #endif > { > int label1; > - TCGv t0, t1, t2; > + TCGv t0, t1, t2, a0; > > if (!s->pe || s->vm86) > goto illegal_op; > t0 = tcg_temp_local_new(); > t1 = tcg_temp_local_new(); > t2 = tcg_temp_local_new(); > + a0 = tcg_temp_local_new(); > ot = OT_WORD; > modrm = ldub_code(s->pc++); > reg = (modrm >> 3) & 7; > @@ -7320,6 +7321,7 @@ static target_ulong disas_insn(DisasContext *s, target_ulong pc_start) > if (mod != 3) { > gen_lea_modrm(s, modrm, ®_addr, &offset_addr); > gen_op_ld_v(ot + s->mem_index, t0, cpu_A0); > + tcg_gen_mov_tl(a0, cpu_A0); > } else { > gen_op_mov_v_reg(ot, t0, rm); > } > @@ -7334,7 +7336,7 @@ static target_ulong disas_insn(DisasContext *s, target_ulong pc_start) > tcg_gen_movi_tl(t2, CC_Z); > gen_set_label(label1); > if (mod != 3) { > - gen_op_st_v(ot + s->mem_index, t0, cpu_A0); > + gen_op_st_v(ot + s->mem_index, t0, a0); > } else { > gen_op_mov_reg_v(ot, rm, t0); > } > @@ -7347,6 +7349,7 @@ static target_ulong disas_insn(DisasContext *s, target_ulong pc_start) > tcg_temp_free(t0); > tcg_temp_free(t1); > tcg_temp_free(t2); > + tcg_temp_free(a0); > } > break; > case 0x102: /* lar */ -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net