From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mv6P8-0006ij-Bc for qemu-devel@nongnu.org; Tue, 06 Oct 2009 05:32:22 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mv6P3-0006hB-Ih for qemu-devel@nongnu.org; Tue, 06 Oct 2009 05:32:21 -0400 Received: from [199.232.76.173] (port=43178 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mv6P3-0006h0-7I for qemu-devel@nongnu.org; Tue, 06 Oct 2009 05:32:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39403) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mv6P2-0007ID-CI for qemu-devel@nongnu.org; Tue, 06 Oct 2009 05:32:16 -0400 Date: Tue, 6 Oct 2009 11:30:13 +0200 From: "Michael S. Tsirkin" Message-ID: <20091006093013.GA8810@redhat.com> References: <1254737223-16129-1-git-send-email-yamahata@valinux.co.jp> <1254737223-16129-17-git-send-email-yamahata@valinux.co.jp> <20091005110143.GE30081@redhat.com> <20091006084822.GA32367%yamahata@valinux.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091006084822.GA32367%yamahata@valinux.co.jp> Subject: [Qemu-devel] Re: [PATCH 16/23] pci: pcie host and mmcfg support. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: qemu-devel@nongnu.org On Tue, Oct 06, 2009 at 05:48:22PM +0900, Isaku Yamahata wrote: > On Mon, Oct 05, 2009 at 01:01:43PM +0200, Michael S. Tsirkin wrote: > > On Mon, Oct 05, 2009 at 07:06:56PM +0900, Isaku Yamahata wrote: > > > This patch adds common routines for pcie host bridge and pcie mmcfg. > > > This will be used by q35 based chipset emulation. > > > > > > Signed-off-by: Isaku Yamahata > > > > Looks like most my comments on this patch were ignored. > > I started repeating them here but then I grew tired, > > so only partially repeated them. Are you going to address this? > > Which mail? Could you please care to resent the previous mail to me? > I'm willing to address your review, and I appreciated your review. > > I'm afraid that your mail was lost somewhere in the net. Ugh, looks like I never sent it. No wonder comments weren't addressed :) Sending out now, sorry about the noise. -- MST