From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MvBFa-0005vD-NU for qemu-devel@nongnu.org; Tue, 06 Oct 2009 10:42:50 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MvBFV-0005r8-VV for qemu-devel@nongnu.org; Tue, 06 Oct 2009 10:42:50 -0400 Received: from [199.232.76.173] (port=58348 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MvBFV-0005qx-Oo for qemu-devel@nongnu.org; Tue, 06 Oct 2009 10:42:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54329) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MvBFV-0003eM-BC for qemu-devel@nongnu.org; Tue, 06 Oct 2009 10:42:45 -0400 Date: Tue, 6 Oct 2009 16:40:43 +0200 From: "Michael S. Tsirkin" Message-ID: <20091006144042.GA3940@redhat.com> References: <1254737223-16129-1-git-send-email-yamahata@valinux.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1254737223-16129-1-git-send-email-yamahata@valinux.co.jp> Subject: [Qemu-devel] Re: [PATCH v4 00/23] pci: various pci clean up and pci express support. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: qemu-devel@nongnu.org On Mon, Oct 05, 2009 at 07:06:40PM +0900, Isaku Yamahata wrote: > Thanks to Michael's review, patches have been much improved > and became much readable. So I think the following are definitely ready to be merged. I'll stick them on my pci tree, this way we won't get conflicts. OK? pci: use helper functions to access config space pci: helper functions to access PCIDevice::config pci: define a constant to represent a unmapped bar and use it. pci: use PCI_SLOT() and PCI_FUNC(). pci: introduce constant PCI_NUM_PINS for the number of interrupt pins, 4. pci: fix PCI_DPRINTF() wrt variadic macro. -- MST