From: Luiz Capitulino <lcapitulino@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org, avi@redhat.com
Subject: [Qemu-devel] Re: [PATCH 02/15] Introduce QList
Date: Wed, 7 Oct 2009 09:48:38 -0300 [thread overview]
Message-ID: <20091007094838.6b5a0fb3@doriath> (raw)
In-Reply-To: <4ACBF0E7.1010207@us.ibm.com>
On Tue, 06 Oct 2009 20:37:43 -0500
Anthony Liguori <aliguori@us.ibm.com> wrote:
> Luiz Capitulino wrote:
[...]
> > +/**
> > + * qlist_destroy_obj(): Free all the memory allocated by a QList
> > + */
> > +static void qlist_destroy_obj(QObject *obj)
> > +{
> > + QList *qlist;
> > + QListEntry *entry, *next_entry;
> > +
> > + assert(obj != NULL);
> >
>
> Usually accepting NULL in a free function makes for nicer exit paths in
> function.
The destroy_obj() functions are always called by qobject_decref()
and it will never pass a NULL qobject.
But qobject_decref() accepts NULL.
I've applied the other changes, some of them also need to be done
in the others data types (will send patches).
next prev parent reply other threads:[~2009-10-07 12:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-07 0:26 [Qemu-devel] [PATCH v2 00/15]: Initial QObject conversion Luiz Capitulino
2009-10-07 0:26 ` [Qemu-devel] [PATCH 01/15] QObject: Accept NULL Luiz Capitulino
2009-10-07 0:26 ` [Qemu-devel] [PATCH 02/15] Introduce QList Luiz Capitulino
2009-10-07 1:37 ` [Qemu-devel] " Anthony Liguori
2009-10-07 12:48 ` Luiz Capitulino [this message]
2009-10-07 0:27 ` [Qemu-devel] [PATCH 03/15] Introduce QList unit-tests Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 04/15] monitor: Add user_print() to mon_cmd_t Luiz Capitulino
2009-10-07 1:40 ` [Qemu-devel] " Anthony Liguori
2009-10-07 12:52 ` Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 05/15] monitor: Handle new and old style handlers Luiz Capitulino
2009-10-07 1:42 ` [Qemu-devel] " Anthony Liguori
2009-10-07 12:54 ` Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 06/15] monitor: do_info(): handle new and old info handlers Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 07/15] monitor: Convert do_quit() do QObject Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 08/15] monitor: Convert do_stop() to QObject Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 09/15] monitor: Convert do_system_reset() " Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 10/15] monitor: Convert do_system_powerdown() " Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 11/15] monitor: Convert do_cont() " Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 12/15] monitor: Convert do_balloon() " Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 13/15] monitor: Convert do_info_version() " Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 14/15] monitor: Convert do_info_balloon() " Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 15/15] monitor: Convert do_info_cpus() " Luiz Capitulino
2009-10-07 1:46 ` [Qemu-devel] " Anthony Liguori
2009-10-07 13:04 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091007094838.6b5a0fb3@doriath \
--to=lcapitulino@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).