From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MvVRf-00015P-GC for qemu-devel@nongnu.org; Wed, 07 Oct 2009 08:16:39 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MvVRa-000134-AC for qemu-devel@nongnu.org; Wed, 07 Oct 2009 08:16:38 -0400 Received: from [199.232.76.173] (port=39380 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MvVRZ-00012t-Q4 for qemu-devel@nongnu.org; Wed, 07 Oct 2009 08:16:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19093) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MvVRZ-0000em-Bw for qemu-devel@nongnu.org; Wed, 07 Oct 2009 08:16:33 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n97CGWIR016412 for ; Wed, 7 Oct 2009 08:16:32 -0400 Received: from localhost (vpn-240-209.phx2.redhat.com [10.3.240.209]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n97CGUkm014671 for ; Wed, 7 Oct 2009 08:16:31 -0400 Date: Wed, 7 Oct 2009 17:45:54 +0530 From: Amit Shah Message-ID: <20091007121554.GC22238@amit-x200.redhat.com> References: <1254913840-10358-1-git-send-email-amit.shah@redhat.com> <1254913840-10358-2-git-send-email-amit.shah@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1254913840-10358-2-git-send-email-amit.shah@redhat.com> Subject: [Qemu-devel] Re: [PATCH 1/3] char: check for initial_reset_issued unnecessary List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On (Wed) Oct 07 2009 [16:40:38], Amit Shah wrote: > At init, qemu_chr_reset is always called with initial_reset_issued set to 1. > So checking for it to be set is not necessary. > > A later patch will make use of initial_reset_issued to send the reset event > only if the char device is opened instead of each time when qemu resets it > > Signed-off-by: Amit Shah > --- > qemu-char.c | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/qemu-char.c b/qemu-char.c > index 8084a67..99ab471 100644 > --- a/qemu-char.c > +++ b/qemu-char.c > @@ -127,7 +127,7 @@ static void qemu_chr_reset_bh(void *opaque) > > void qemu_chr_reset(CharDriverState *s) > { > - if (s->bh == NULL && initial_reset_issued) { > + if (s->bh == NULL) { > s->bh = qemu_bh_new(qemu_chr_reset_bh, s); > qemu_bh_schedule(s->bh); > } > @@ -137,11 +137,10 @@ void qemu_chr_initial_reset(void) > { > CharDriverState *chr; > > - initial_reset_issued = 1; > - > QTAILQ_FOREACH(chr, &chardevs, next) { > qemu_chr_reset(chr); > } > + initial_reset_issued = 1; > } Actually this won't work since the actual reset is done in a bh_schedule. I'll have to find out another way of doing this. Amit