From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MvZUd-0008BT-Rd for qemu-devel@nongnu.org; Wed, 07 Oct 2009 12:35:59 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MvZUX-00088S-0w for qemu-devel@nongnu.org; Wed, 07 Oct 2009 12:35:59 -0400 Received: from [199.232.76.173] (port=39938 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MvZUW-00088G-Q1 for qemu-devel@nongnu.org; Wed, 07 Oct 2009 12:35:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6799) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MvZUW-0004RF-8G for qemu-devel@nongnu.org; Wed, 07 Oct 2009 12:35:52 -0400 Date: Wed, 7 Oct 2009 18:33:29 +0200 From: "Michael S. Tsirkin" Message-ID: <20091007163329.GA10857@redhat.com> References: <20091007132006.GA9668@redhat.com> <4ACCC1A5.5020306@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4ACCC1A5.5020306@codemonkey.ws> Subject: [Qemu-devel] Re: [PATCH] Revert "posix-aio-compat: avoid signal race when spawning a thread" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org On Wed, Oct 07, 2009 at 11:28:21AM -0500, Anthony Liguori wrote: > >> There's nothing to review in this particular case, the thing was plain >> broken, besides same thing was already discussed between me and >> Andrzej, see for instance: >> http://www.mail-archive.com/qemu-devel@nongnu.org/msg09542.html >> >> Needless to say the revert is broken also. >> > > Yeah, I understand the race the original commit fixes but I don't > understand how the original commit broke WinXP. > > Do you have further insight Michael? Nope, I just bisected and then reverted and tested that this helps. > Blindly reverting something that > appears right because of a regression is likely just papering over a > bigger problem. > > Regards, > > Anthony Liguori >