From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MvcpV-00089Y-Uo
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 16:09:45 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MvcpR-000836-0s
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 16:09:45 -0400
Received: from [199.232.76.173] (port=55070 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MvcpQ-00082t-Qq
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 16:09:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:19099)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1MvcpQ-0004JH-4Q
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 16:09:40 -0400
Date: Wed, 7 Oct 2009 22:07:35 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20091007200735.GA4085@redhat.com>
References: <200910051452.n95EphXY002170@d03av01.boulder.ibm.com>
	<4ACC4F43.1010906@redhat.com> <20091007195338.GA3923@redhat.com>
	<4ACCF38F.4040309@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4ACCF38F.4040309@redhat.com>
Subject: [Qemu-devel] Re: [Qemu-commits] [COMMIT c0b1905] qemu/pci: reset
	device registers on bus reset
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, kvm-devel <kvm@vger.kernel.org>

On Wed, Oct 07, 2009 at 10:01:19PM +0200, Avi Kivity wrote:
> On 10/07/2009 09:53 PM, Michael S. Tsirkin wrote:
>> On Wed, Oct 07, 2009 at 10:20:19AM +0200, Avi Kivity wrote:
>>    
>>> On 10/05/2009 04:53 PM, Anthony Liguori wrote:
>>>      
>>>> From: Michael S. Tsirkin<mst@redhat.com>
>>>>
>>>> Reset BARs and a couple of other registers on bus reset, as per PCI
>>>> spec.
>>>>
>>>>        
>>> This commit breaks Windows XP restart.  After a restart Windows switches
>>> from 800x600 cirrus logic vga to 640x480 standard vga.  My guess is that
>>> this is due to two mutually-cancelling bugs:
>>>      
>> Could you please tell me how to reproduce the problem exactly?
>> I tried several configurations but in all of them windows
>> seems to keep 800x600 across restarts, and shows display adapter
>> as cirrus vga.
>>    
>
> Clean Windows XP install (-smp 2), boot, reboot.
>
> After restart it also loses S3 (so Standby is gr[ae]yed out in the  
> shutdown menu).

OK, see it now, finally. I'll work on it.

> -- 
> Do not meddle in the internals of kernels, for they are subtle and quick to panic.