From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MvdPL-00087O-NE
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 16:46:47 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MvdPG-0007xv-0O
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 16:46:46 -0400
Received: from [199.232.76.173] (port=34560 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MvdPF-0007xI-Mo
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 16:46:41 -0400
Received: from mx1.redhat.com ([209.132.183.28]:23963)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1MvdPE-0001jz-G5
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 16:46:40 -0400
Date: Wed, 7 Oct 2009 22:44:22 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20091007204421.GC4085@redhat.com>
References: <20091007132006.GA9668@redhat.com>
	<Pine.LNX.4.64.0910072000090.2178@linmac.oyster.ru>
	<4ACCC1A5.5020306@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4ACCC1A5.5020306@codemonkey.ws>
Subject: [Qemu-devel] Re: [PATCH] Revert "posix-aio-compat: avoid signal
	race when spawning a thread"
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

On Wed, Oct 07, 2009 at 11:28:21AM -0500, Anthony Liguori wrote:
>
>> There's nothing to review in this particular case, the thing was plain
>> broken, besides same thing was already discussed between me and
>> Andrzej, see for instance:
>> http://www.mail-archive.com/qemu-devel@nongnu.org/msg09542.html
>>
>> Needless to say the revert is broken also.
>>   
>
> Yeah, I understand the race the original commit fixes but I don't  
> understand how the original commit broke WinXP.
>
> Do you have further insight Michael?

My guess is that SIGALARM gets lost, this somehow leads to
disk request to timeout. Possible?

> Blindly reverting something that  appears right because of a
> regression is likely just papering over a  bigger problem.
>
> Regards,
>
> Anthony Liguori
>