From: Jamie Lokier <jamie@shareable.org>
To: malc <av1474@comtv.ru>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH] Revert "posix-aio-compat: avoid signal race when spawning a thread"
Date: Thu, 8 Oct 2009 02:47:42 +0100 [thread overview]
Message-ID: <20091008014742.GA15601@shareable.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0910080059550.4776@linmac.oyster.ru>
malc wrote:
> > The use of sigprocmask() is unspecified in a
> > multithreaded process; see pthread_sigmask(3).
> >
> > Does it matter?
>
> One of the patches i've asked you to try today replaced sigprocmask with
> pthread_sigmask, you've said it did nothing. In any case, strictly
> speaking, the code is wrong, so yes it does matter in theory.
It won't matter on a Linux host (they are the same), but
pthread_sigmask should be used because it's Right(tm) and it could
make a difference on some other host.
-- Jamie
next prev parent reply other threads:[~2009-10-08 1:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-07 13:20 [Qemu-devel] [PATCH] Revert "posix-aio-compat: avoid signal race when spawning a thread" Michael S. Tsirkin
2009-10-07 16:04 ` [Qemu-devel] " malc
2009-10-07 16:28 ` Anthony Liguori
2009-10-07 16:33 ` Michael S. Tsirkin
2009-10-07 20:44 ` Michael S. Tsirkin
2009-10-07 20:54 ` malc
2009-10-07 20:55 ` Michael S. Tsirkin
2009-10-07 21:01 ` malc
2009-10-08 1:47 ` Jamie Lokier [this message]
2009-10-08 2:48 ` malc
2009-10-08 15:15 ` Jamie Lokier
2009-10-08 16:39 ` malc
2009-10-09 11:12 ` Jamie Lokier
2009-10-09 13:13 ` malc
2009-10-08 21:24 ` Michael S. Tsirkin
2009-10-08 21:50 ` Anthony Liguori
2009-10-08 21:51 ` Anthony Liguori
2009-10-09 11:13 ` Jamie Lokier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091008014742.GA15601@shareable.org \
--to=jamie@shareable.org \
--cc=av1474@comtv.ru \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).