From: Gleb Natapov <gleb@redhat.com>
To: Kevin O'Connor <kevin@koconnor.net>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 2/2] Add support for passing additional acpi tables from qemu.
Date: Thu, 8 Oct 2009 08:10:35 +0200 [thread overview]
Message-ID: <20091008061035.GB16702@redhat.com> (raw)
In-Reply-To: <20091007234849.GB15407@morn.localdomain>
On Wed, Oct 07, 2009 at 07:48:49PM -0400, Kevin O'Connor wrote:
> On Wed, Oct 07, 2009 at 03:21:44PM +0200, Gleb Natapov wrote:
> > --- a/src/config.h
> > +++ b/src/config.h
> > @@ -13,7 +13,7 @@
> > #define CONFIG_APPNAME4 "BXPC"
> >
> > // Configure for use with KVM.
> > -#define CONFIG_KVM 0
> > +#define CONFIG_KVM 1
>
> Was this change intentional? If so, please explain why it's needed.
>
It was not!
> I have noticed that qemu-0.11 only works properly if CONFIG_KVM is
> enabled. However, this option pulls in some settings that really are
> specific to kvm.
>
I plan to get rid of CONFIG_KVM entirely.
> Otherwise, the patch looks good to me.
>
> -Kevin
--
Gleb.
next prev parent reply other threads:[~2009-10-08 6:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-07 13:21 [Qemu-devel] [PATCH 1/2] Cleanup acpi table creation Gleb Natapov
2009-10-07 13:21 ` [Qemu-devel] [PATCH 2/2] Add support for passing additional acpi tables from qemu Gleb Natapov
2009-10-07 23:48 ` [Qemu-devel] " Kevin O'Connor
2009-10-08 6:10 ` Gleb Natapov [this message]
2009-10-07 23:45 ` [Qemu-devel] Re: [PATCH 1/2] Cleanup acpi table creation Kevin O'Connor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091008061035.GB16702@redhat.com \
--to=gleb@redhat.com \
--cc=kevin@koconnor.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).