From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mvmf7-0007og-On
	for qemu-devel@nongnu.org; Thu, 08 Oct 2009 02:39:41 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mvmf2-0007nl-Ai
	for qemu-devel@nongnu.org; Thu, 08 Oct 2009 02:39:40 -0400
Received: from [199.232.76.173] (port=37497 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mvmf2-0007ni-5X
	for qemu-devel@nongnu.org; Thu, 08 Oct 2009 02:39:36 -0400
Received: from mx20.gnu.org ([199.232.41.8]:9649)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <gleb@redhat.com>) id 1Mvmf1-0000cR-Ri
	for qemu-devel@nongnu.org; Thu, 08 Oct 2009 02:39:35 -0400
Received: from mx1.redhat.com ([209.132.183.28])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@redhat.com>) id 1Mvmf1-0000d3-1K
	for qemu-devel@nongnu.org; Thu, 08 Oct 2009 02:39:35 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n986dXBp014479
	for <qemu-devel@nongnu.org>; Thu, 8 Oct 2009 02:39:33 -0400
Date: Thu, 8 Oct 2009 08:10:35 +0200
From: Gleb Natapov <gleb@redhat.com>
Message-ID: <20091008061035.GB16702@redhat.com>
References: <1254921704-18810-1-git-send-email-gleb@redhat.com>
	<1254921704-18810-2-git-send-email-gleb@redhat.com>
	<20091007234849.GB15407@morn.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20091007234849.GB15407@morn.localdomain>
Subject: [Qemu-devel] Re: [PATCH 2/2] Add support for passing additional
 acpi tables from qemu.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin O'Connor <kevin@koconnor.net>
Cc: qemu-devel@nongnu.org

On Wed, Oct 07, 2009 at 07:48:49PM -0400, Kevin O'Connor wrote:
> On Wed, Oct 07, 2009 at 03:21:44PM +0200, Gleb Natapov wrote:
> > --- a/src/config.h
> > +++ b/src/config.h
> > @@ -13,7 +13,7 @@
> >  #define CONFIG_APPNAME4 "BXPC"
> >  
> >  // Configure for use with KVM.
> > -#define CONFIG_KVM 0
> > +#define CONFIG_KVM 1
> 
> Was this change intentional?  If so, please explain why it's needed.
> 
It was not!

> I have noticed that qemu-0.11 only works properly if CONFIG_KVM is
> enabled.  However, this option pulls in some settings that really are
> specific to kvm.
> 
I plan to get rid of CONFIG_KVM entirely.

> Otherwise, the patch looks good to me.
> 
> -Kevin

--
			Gleb.