From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MvuGU-0007Fs-4Z
	for qemu-devel@nongnu.org; Thu, 08 Oct 2009 10:46:46 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MvuGO-0007Bq-Sq
	for qemu-devel@nongnu.org; Thu, 08 Oct 2009 10:46:45 -0400
Received: from [199.232.76.173] (port=35764 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MvuGO-0007Bd-Kt
	for qemu-devel@nongnu.org; Thu, 08 Oct 2009 10:46:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:7420)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <glommer@redhat.com>) id 1MvuGO-0003RO-4S
	for qemu-devel@nongnu.org; Thu, 08 Oct 2009 10:46:40 -0400
Date: Thu, 8 Oct 2009 11:46:33 -0300
From: Glauber Costa <glommer@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH v2 4/9] provide in-kernel apic
Message-ID: <20091008144633.GT8092@mothafucka.localdomain>
References: <1254953315-5761-1-git-send-email-glommer@redhat.com>
	<1254953315-5761-2-git-send-email-glommer@redhat.com>
	<1254953315-5761-3-git-send-email-glommer@redhat.com>
	<1254953315-5761-4-git-send-email-glommer@redhat.com>
	<1254953315-5761-5-git-send-email-glommer@redhat.com>
	<4ACDEF42.6020706@us.ibm.com> <4ACDF297.9010303@redhat.com>
	<4ACDF69B.5000000@codemonkey.ws> <4ACDF7DD.1010803@redhat.com>
	<4ACDF991.7030202@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4ACDF991.7030202@codemonkey.ws>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Avi Kivity <avi@redhat.com>, kvm-devel <kvm@vger.kernel.org>, qemu-devel@nongnu.org

On Thu, Oct 08, 2009 at 09:39:13AM -0500, Anthony Liguori wrote:
> The sync stuff is really ugly too.  It would be much cleaner to have a  
> separate state for the in-kernel device models that saved the structures  
> from the kernel directly instead of having to translate between formats.  
> More straight forward code means it's all easier to understand, easier to 
> debug, etc.
>
One may arguee that I am stupid, but I have caught myself reading code that
was totally unused in the quest for irqchip related bugs...