From: "Michael S. Tsirkin" <mst@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
kvm-devel <kvm@vger.kernel.org>
Subject: [Qemu-devel] Re: [PATCH 0/3] qemu: reset-related fixes
Date: Thu, 8 Oct 2009 17:02:51 +0200 [thread overview]
Message-ID: <20091008150251.GA12460@redhat.com> (raw)
In-Reply-To: <20091008145226.GA12275@redhat.com>
On Thu, Oct 08, 2009 at 04:52:26PM +0200, Michael S. Tsirkin wrote:
> On Wed, Oct 07, 2009 at 10:20:19AM +0200, Avi Kivity wrote:
> >> Reset BARs and a couple of other registers on bus reset, as per PCI
> >> spec.
> >>
> >
> > This commit breaks Windows XP restart. After a restart Windows switches
> > from 800x600 cirrus logic vga to 640x480 standard vga.
>
> So I think this is a bios bug. Patchset fixing this applied.
>
> So, what's the best way to propagate the fixes upstream?
> Avi, Anthony, please advise.
>
> Avi, after applying this, you need to generate a new bios binary.
>
> Anthony, qemu keeps bios binaries in source tree.
> I can't post a patch changing these, can I?
> Only people with git access can change them.
>
> BTW, can't we keep the sources around the like qemu-kvm does?
> It would be best if pc-bios used git, then we would
> include a submodule, as it is we can set up a git-cvs
> mirror at qemu site, and then include a submodule.
> Makes sense?
On this last point, it was pointed out to me that
this is what we have already. Sorry about the noise.
> Michael S. Tsirkin (3):
> pc-bios: enable io/memory unconditionally
> qemu: make cirrus init value pci spec compliant
> qemu: cleanup unused macros in cirrus
>
> hw/cirrus_vga.c | 38 +-------------------------------------
> kvm/bios/rombios32.c | 18 +++++++-----------
> 2 files changed, 8 insertions(+), 48 deletions(-)
>
> --
> MST
>
>
next prev parent reply other threads:[~2009-10-08 15:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-08 14:52 [Qemu-devel] [PATCH 0/3] qemu: reset-related fixes Michael S. Tsirkin
2009-10-08 15:02 ` Michael S. Tsirkin [this message]
2009-10-08 15:16 ` [Qemu-devel] " Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091008150251.GA12460@redhat.com \
--to=mst@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).