From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MvuYB-0007uk-Od for qemu-devel@nongnu.org; Thu, 08 Oct 2009 11:05:03 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MvuY6-0007nK-Gv for qemu-devel@nongnu.org; Thu, 08 Oct 2009 11:05:03 -0400 Received: from [199.232.76.173] (port=40302 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MvuY6-0007n3-A8 for qemu-devel@nongnu.org; Thu, 08 Oct 2009 11:04:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4558) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MvuY4-00081G-Sx for qemu-devel@nongnu.org; Thu, 08 Oct 2009 11:04:57 -0400 Date: Thu, 8 Oct 2009 17:02:51 +0200 From: "Michael S. Tsirkin" Message-ID: <20091008150251.GA12460@redhat.com> References: <20091008145226.GA12275@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091008145226.GA12275@redhat.com> Subject: [Qemu-devel] Re: [PATCH 0/3] qemu: reset-related fixes List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Anthony Liguori , "qemu-devel@nongnu.org" , kvm-devel On Thu, Oct 08, 2009 at 04:52:26PM +0200, Michael S. Tsirkin wrote: > On Wed, Oct 07, 2009 at 10:20:19AM +0200, Avi Kivity wrote: > >> Reset BARs and a couple of other registers on bus reset, as per PCI > >> spec. > >> > > > > This commit breaks Windows XP restart. After a restart Windows switches > > from 800x600 cirrus logic vga to 640x480 standard vga. > > So I think this is a bios bug. Patchset fixing this applied. > > So, what's the best way to propagate the fixes upstream? > Avi, Anthony, please advise. > > Avi, after applying this, you need to generate a new bios binary. > > Anthony, qemu keeps bios binaries in source tree. > I can't post a patch changing these, can I? > Only people with git access can change them. > > BTW, can't we keep the sources around the like qemu-kvm does? > It would be best if pc-bios used git, then we would > include a submodule, as it is we can set up a git-cvs > mirror at qemu site, and then include a submodule. > Makes sense? On this last point, it was pointed out to me that this is what we have already. Sorry about the noise. > Michael S. Tsirkin (3): > pc-bios: enable io/memory unconditionally > qemu: make cirrus init value pci spec compliant > qemu: cleanup unused macros in cirrus > > hw/cirrus_vga.c | 38 +------------------------------------- > kvm/bios/rombios32.c | 18 +++++++----------- > 2 files changed, 8 insertions(+), 48 deletions(-) > > -- > MST > >