From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MvvXe-0006Ob-Rx for qemu-devel@nongnu.org; Thu, 08 Oct 2009 12:08:34 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MvvXY-0006Fj-Ol for qemu-devel@nongnu.org; Thu, 08 Oct 2009 12:08:32 -0400 Received: from [199.232.76.173] (port=57284 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MvvXY-0006F7-ES for qemu-devel@nongnu.org; Thu, 08 Oct 2009 12:08:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35280) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MvvXX-0004XR-GN for qemu-devel@nongnu.org; Thu, 08 Oct 2009 12:08:27 -0400 Date: Thu, 8 Oct 2009 18:06:23 +0200 From: "Michael S. Tsirkin" Message-ID: <20091008160623.GA13710@redhat.com> References: <20091008145241.GC12275@redhat.com> <4ACE0559.5040206@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4ACE0559.5040206@redhat.com> Subject: [Qemu-devel] Re: [PATCH 2/3] qemu: make cirrus init value pci spec compliant List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Anthony Liguori , "qemu-devel@nongnu.org" , kvm-devel On Thu, Oct 08, 2009 at 05:29:29PM +0200, Avi Kivity wrote: > On 10/08/2009 04:52 PM, Michael S. Tsirkin wrote: >> PCI memory should be disabled at reset, otherwise >> we might claim transactions at address 0. >> I/O should also be disabled, although for cirrus >> it is harmless to enable it as we do not >> have I/O bar. >> >> Note: need bios fix for this patch to work: >> currently pc-bios incorrently assumes that it does not >> need to enable i/o unless device has i/o bar. >> >> Signed-off-by: Michael S. Tsirkin >> --- >> hw/cirrus_vga.c | 1 - >> 1 files changed, 0 insertions(+), 1 deletions(-) >> >> diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c >> index 1feb827..c54ac65 100644 >> --- a/hw/cirrus_vga.c >> +++ b/hw/cirrus_vga.c >> @@ -3248,7 +3248,6 @@ static int pci_cirrus_vga_initfn(PCIDevice *dev) >> /* setup PCI */ >> pci_config_set_vendor_id(pci_conf, PCI_VENDOR_ID_CIRRUS); >> pci_config_set_device_id(pci_conf, device_id); >> - pci_conf[0x04] = PCI_COMMAND_IOACCESS | PCI_COMMAND_MEMACCESS; >> pci_config_set_class(pci_conf, PCI_CLASS_DISPLAY_VGA); >> pci_conf[PCI_HEADER_TYPE] = PCI_HEADER_TYPE_NORMAL; >> > > This needs to be conditional on the machine type. Old machines must > retain this code for live migration to work (we need to live migrate the > bios, so we can't assume the bios fix is in during live migration from > older qemus). No, if you migrate from older qemu you will be fine as command is enabled there on init. Only migration *to* older qemu might create a problem and then only if you manage to migrate after pci was reset but before bios set the register, which is a small window. Do we really want to update machine type for this? > -- > error compiling committee.c: too many arguments to function