From: Jamie Lokier <jamie@shareable.org>
To: Avi Kivity <avi@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Glauber Costa <glommer@redhat.com>,
kvm-devel <kvm@vger.kernel.org>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH v2 3/9] provide in-kernel ioapic
Date: Thu, 8 Oct 2009 17:07:26 +0100 [thread overview]
Message-ID: <20091008160726.GD29691@shareable.org> (raw)
In-Reply-To: <4ACDEF03.6010406@redhat.com>
Avi Kivity wrote:
> On 10/08/2009 03:49 PM, Anthony Liguori wrote:
> >Glauber Costa wrote:
> >>This patch provides kvm with an in-kernel ioapic. We are currently
> >>not enabling it.
> >>The code is heavily based on what's in qemu-kvm.git.
> >
> >It really ought to be it's own file and own device model. Having the
> >code mixed in with ioapic.c is confusing because it's unclear what
> >code is in use when the in-kernel model is used.
>
> I disagree. It's the same device with the same guest-visible interface
> and the same host-visible interface (save/restore, 'info ioapic' if we
> write one). Splitting it into two files will only result in code
> duplication.
>
> Think of it as an ioapic accelerator.
Haven't we already confirmed that it *isn't* just an ioapic accelerator
because you can't migrate between in-kernel iopic and qemu's ioapic?
Imho, if they cannot be swapped transparently, they are different
device emulations.
OF course there's nothing wrong with sharing lots of code.
Maybe ioapic.c and ioapic-kvm.c, with shared code in ioapic-common.c?
-- Jamie
next prev parent reply other threads:[~2009-10-08 16:07 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-07 22:08 [Qemu-devel] [PATCH v2] Add in-kernel irqchip Glauber Costa
2009-10-07 22:08 ` [Qemu-devel] [PATCH v2 1/9] add base-addr field to io apic state Glauber Costa
2009-10-07 22:08 ` [Qemu-devel] [PATCH v2 2/9] Save missing fields in VMState Glauber Costa
2009-10-07 22:08 ` [Qemu-devel] [PATCH v2 3/9] provide in-kernel ioapic Glauber Costa
2009-10-07 22:08 ` [Qemu-devel] [PATCH v2 4/9] provide in-kernel apic Glauber Costa
2009-10-07 22:08 ` [Qemu-devel] [PATCH v2 5/9] provide apic_set_irq_delivered Glauber Costa
2009-10-07 22:08 ` [Qemu-devel] [PATCH v2 6/9] provide in-kernel i8259 chip Glauber Costa
2009-10-07 22:08 ` [Qemu-devel] [PATCH v2 7/9] initialize " Glauber Costa
2009-10-07 22:08 ` [Qemu-devel] [PATCH v2 8/9] Initialize in-kernel irqchip Glauber Costa
2009-10-07 22:08 ` [Qemu-devel] [PATCH v2 9/9] Add -kvm option Glauber Costa
2009-10-07 23:00 ` [Qemu-devel] " Anthony Liguori
2009-10-07 23:14 ` Glauber Costa
2009-10-07 23:28 ` Anthony Liguori
2009-10-12 11:58 ` Gerd Hoffmann
2009-10-12 14:04 ` Anthony Liguori
2009-10-12 15:34 ` Gerd Hoffmann
2009-10-12 16:31 ` Anthony Liguori
2009-10-13 8:05 ` Gerd Hoffmann
2009-10-13 15:33 ` Anthony Liguori
2009-10-13 19:26 ` Markus Armbruster
2009-10-13 20:43 ` Anthony Liguori
2009-10-14 8:08 ` Gerd Hoffmann
2009-10-13 15:36 ` Anthony Liguori
2009-10-13 22:57 ` Jamie Lokier
2009-10-08 14:07 ` Avi Kivity
2009-10-08 14:23 ` Anthony Liguori
2009-10-08 14:30 ` Avi Kivity
2009-10-08 14:33 ` Anthony Liguori
2009-10-08 14:41 ` Avi Kivity
2009-10-08 14:56 ` Anthony Liguori
2009-10-08 15:05 ` Avi Kivity
2009-10-08 15:14 ` Anthony Liguori
2009-10-12 11:15 ` Gerd Hoffmann
2009-10-08 14:34 ` Gleb Natapov
2009-10-08 12:02 ` [Qemu-devel] Re: [PATCH v2 7/9] initialize i8259 chip Jan Kiszka
2009-10-08 13:55 ` [Qemu-devel] Re: [PATCH v2 4/9] provide in-kernel apic Anthony Liguori
2009-10-08 14:09 ` Avi Kivity
2009-10-08 14:22 ` Glauber Costa
2009-10-09 10:06 ` Jamie Lokier
2009-10-09 14:30 ` Glauber Costa
2009-10-09 16:48 ` Jamie Lokier
2009-10-09 18:06 ` Glauber Costa
2009-10-09 19:49 ` Anthony Liguori
2009-10-11 9:10 ` Avi Kivity
2009-10-12 13:41 ` Anthony Liguori
2009-10-08 14:26 ` Anthony Liguori
2009-10-08 14:31 ` Avi Kivity
2009-10-08 14:39 ` Anthony Liguori
2009-10-08 14:46 ` Glauber Costa
2009-10-08 14:44 ` Glauber Costa
2009-10-08 11:46 ` [Qemu-devel] Re: [PATCH v2 3/9] provide in-kernel ioapic Jan Kiszka
2009-10-08 13:49 ` Anthony Liguori
2009-10-08 13:54 ` Avi Kivity
2009-10-08 15:53 ` Jan Kiszka
2009-10-08 16:07 ` Jamie Lokier [this message]
2009-10-08 16:12 ` Anthony Liguori
2009-10-08 16:17 ` Avi Kivity
2009-10-08 16:22 ` Gleb Natapov
2009-10-08 16:29 ` Avi Kivity
2009-10-08 16:34 ` Gleb Natapov
2009-10-08 16:42 ` Avi Kivity
2009-10-08 17:11 ` Gleb Natapov
2009-10-09 10:02 ` Jamie Lokier
2009-10-09 12:02 ` Gleb Natapov
2009-10-09 14:32 ` Glauber Costa
2009-10-09 16:49 ` Jamie Lokier
[not found] ` <m31vlctk9q.fsf@neno.mitica>
2009-10-09 21:34 ` Glauber Costa
2009-10-12 13:20 ` Anthony Liguori
2009-10-12 14:18 ` Jamie Lokier
2009-10-12 14:49 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091008160726.GD29691@shareable.org \
--to=jamie@shareable.org \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).