From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MvyD0-0005jJ-Al
	for qemu-devel@nongnu.org; Thu, 08 Oct 2009 14:59:26 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MvyCv-0005g8-Na
	for qemu-devel@nongnu.org; Thu, 08 Oct 2009 14:59:26 -0400
Received: from [199.232.76.173] (port=41276 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MvyCv-0005fy-He
	for qemu-devel@nongnu.org; Thu, 08 Oct 2009 14:59:21 -0400
Received: from mtaout01-winn.ispmail.ntl.com ([81.103.221.47]:2037)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <sdbrady@ntlworld.com>) id 1MvyCv-0006i0-0k
	for qemu-devel@nongnu.org; Thu, 08 Oct 2009 14:59:21 -0400
Received: from aamtaout03-winn.ispmail.ntl.com ([81.103.221.35])
	by mtaout01-winn.ispmail.ntl.com
	(InterMail vM.7.08.04.00 201-2186-134-20080326) with ESMTP id
	<20091008185911.QWZQ17029.mtaout01-winn.ispmail.ntl.com@aamtaout03-winn.ispmail.ntl.com>
	for <qemu-devel@nongnu.org>; Thu, 8 Oct 2009 19:59:11 +0100
Received: from miranda.arrow ([213.107.24.213])
	by aamtaout03-winn.ispmail.ntl.com
	(InterMail vG.2.02.00.01 201-2161-120-102-20060912) with ESMTP id
	<20091008185911.IOLB2093.aamtaout03-winn.ispmail.ntl.com@miranda.arrow>
	for <qemu-devel@nongnu.org>; Thu, 8 Oct 2009 19:59:11 +0100
Received: from sdb by miranda.arrow with local (Exim 4.63)
	(envelope-from <sdbrady@ntlworld.com>) id 1MvyE3-0000uh-T6
	for qemu-devel@nongnu.org; Thu, 08 Oct 2009 20:00:32 +0100
Date: Thu, 8 Oct 2009 20:00:31 +0100
From: Stuart Brady <sdbrady@ntlworld.com>
Subject: Re: [Qemu-devel] [PATCH] eepro100: Remove unused device status entries
Message-ID: <20091008190031.GA3496@miranda.arrow>
References: <4AC9F29B.5060404@codemonkey.ws>
	<1254982537-6377-1-git-send-email-weil@mail.berlios.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1254982537-6377-1-git-send-email-weil@mail.berlios.de>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Thu, Oct 08, 2009 at 08:15:37AM +0200, Stefan Weil wrote:

[snip entertaining patch description]

> -    if (version_id >= 2) {
> -        qemu_get_8s(f, &s->rxcr);
> -    } else {
> -        s->rxcr = 0x0c;
> -    }
> +    /* Skip unused entries. */
> +    qemu_fseek(f, 32, SEEK_CUR);

Shouldn't the number of bytes skipped depend on the version ID?

Cheers,
-- 
Stuart Brady