From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MwDQ4-00085s-JX
	for qemu-devel@nongnu.org; Fri, 09 Oct 2009 07:13:56 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MwDPz-00084u-4z
	for qemu-devel@nongnu.org; Fri, 09 Oct 2009 07:13:55 -0400
Received: from [199.232.76.173] (port=52961 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MwDPy-00084r-IB
	for qemu-devel@nongnu.org; Fri, 09 Oct 2009 07:13:50 -0400
Received: from mail2.shareable.org ([80.68.89.115]:53783)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <jamie@shareable.org>) id 1MwDPx-0001JG-Sr
	for qemu-devel@nongnu.org; Fri, 09 Oct 2009 07:13:50 -0400
Date: Fri, 9 Oct 2009 12:13:42 +0100
From: Jamie Lokier <jamie@shareable.org>
Subject: Re: [Qemu-devel] Re: [PATCH] Revert "posix-aio-compat: avoid signal
	race when spawning a thread"
Message-ID: <20091009111342.GF6576@shareable.org>
References: <Pine.LNX.4.64.0910072000090.2178@linmac.oyster.ru>
	<4ACCC1A5.5020306@codemonkey.ws> <20091007204421.GC4085@redhat.com>
	<Pine.LNX.4.64.0910080053350.4678@linmac.oyster.ru>
	<20091007205523.GA4783@redhat.com>
	<Pine.LNX.4.64.0910080059550.4776@linmac.oyster.ru>
	<20091008014742.GA15601@shareable.org>
	<Pine.LNX.4.64.0910080647510.2109@linmac.oyster.ru>
	<20091008151527.GB29691@shareable.org>
	<20091008212421.GA7229@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20091008212421.GA7229@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org

Michael S. Tsirkin wrote:
> And qemu_service_io does a *ton* of things.
> Questions:
> -  Do we need the call to qemu_service_io? Seems to
>    behave the same with and without it.
> -  Are all of the data structures touched by qemu_service_io
>    protected by blocking signals before access?

Plus:

-  Are all the things done by qemu_service_io async-signal-safe?
   E.g. any use of pthread primitives is not async-signal-safe.
   I don't know if thread-local storage is.

-- Jamie