From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mx1Oe-0002aU-5h for qemu-devel@nongnu.org; Sun, 11 Oct 2009 12:35:48 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mx1OZ-0002ZZ-Jx for qemu-devel@nongnu.org; Sun, 11 Oct 2009 12:35:47 -0400 Received: from [199.232.76.173] (port=47925 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mx1OZ-0002ZW-H3 for qemu-devel@nongnu.org; Sun, 11 Oct 2009 12:35:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3895) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mx1OZ-000524-3i for qemu-devel@nongnu.org; Sun, 11 Oct 2009 12:35:43 -0400 Date: Sun, 11 Oct 2009 18:33:34 +0200 From: "Michael S. Tsirkin" Subject: Re: [Qemu-devel] Re: [PATCH 2/3] qemu: make cirrus init value pci spec compliant Message-ID: <20091011163334.GA6248@redhat.com> References: <20091011133626.GA10229@redhat.com> <20091011134559.GN16702@redhat.com> <20091011135240.GA10277@redhat.com> <20091011135748.GO16702@redhat.com> <20091011143535.GA10401@redhat.com> <4AD1EED3.5000901@redhat.com> <20091011144428.GA10429@redhat.com> <4AD1F173.8040401@redhat.com> <20091011161232.GA10132@redhat.com> <4AD206BE.3050904@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AD206BE.3050904@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Anthony Liguori , "qemu-devel@nongnu.org" , Gleb Natapov , kvm-devel On Sun, Oct 11, 2009 at 06:24:30PM +0200, Avi Kivity wrote: > On 10/11/2009 06:12 PM, Michael S. Tsirkin wrote: >> >>> The guest is running during the upgrade, so the qemu executable is still >>> from the old install (but deleted). >>> >> Oh, I don't think we should re-read it from file each time. >> We could read it at startup, keep a copy around for reboots. >> > > We do that, see hw/loader.c. Which function specifically? > -- > error compiling committee.c: too many arguments to function