From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mx1U2-0005Mq-TZ
	for qemu-devel@nongnu.org; Sun, 11 Oct 2009 12:41:23 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mx1Ty-0005JA-74
	for qemu-devel@nongnu.org; Sun, 11 Oct 2009 12:41:22 -0400
Received: from [199.232.76.173] (port=42075 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mx1Ty-0005J3-0u
	for qemu-devel@nongnu.org; Sun, 11 Oct 2009 12:41:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:1026)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1Mx1Tx-0005ul-A8
	for qemu-devel@nongnu.org; Sun, 11 Oct 2009 12:41:17 -0400
Date: Sun, 11 Oct 2009 18:39:09 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH 2/3] qemu: make cirrus init value pci
	spec compliant
Message-ID: <20091011163909.GA6261@redhat.com>
References: <20091011135240.GA10277@redhat.com>
	<20091011135748.GO16702@redhat.com>
	<20091011143535.GA10401@redhat.com> <4AD1EED3.5000901@redhat.com>
	<20091011144428.GA10429@redhat.com> <4AD1F173.8040401@redhat.com>
	<20091011161232.GA10132@redhat.com> <4AD206BE.3050904@redhat.com>
	<20091011163334.GA6248@redhat.com> <4AD209BD.5020300@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4AD209BD.5020300@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Gleb Natapov <gleb@redhat.com>, kvm-devel <kvm@vger.kernel.org>

On Sun, Oct 11, 2009 at 06:37:17PM +0200, Avi Kivity wrote:
> On 10/11/2009 06:33 PM, Michael S. Tsirkin wrote:
>> On Sun, Oct 11, 2009 at 06:24:30PM +0200, Avi Kivity wrote:
>>    
>>> On 10/11/2009 06:12 PM, Michael S. Tsirkin wrote:
>>>      
>>>>        
>>>>> The guest is running during the upgrade, so the qemu executable is still
>>>>> from the old install (but deleted).
>>>>>
>>>>>          
>>>> Oh, I don't think we should re-read it from file each time.
>>>> We could read it at startup, keep a copy around for reboots.
>>>>
>>>>        
>>> We do that, see hw/loader.c.
>>>      
>> Which function specifically?
>>    
>
> rom_add_file().

Is it used for BIOS? pc.c seems to call this for initrd only?

> -- 
> error compiling committee.c: too many arguments to function