From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MxHpN-0004Tj-V4
	for qemu-devel@nongnu.org; Mon, 12 Oct 2009 06:08:30 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MxHpJ-0004SH-2R
	for qemu-devel@nongnu.org; Mon, 12 Oct 2009 06:08:29 -0400
Received: from [199.232.76.173] (port=45673 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MxHpI-0004SE-Ts
	for qemu-devel@nongnu.org; Mon, 12 Oct 2009 06:08:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44678)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@redhat.com>) id 1MxHpI-0005fE-EJ
	for qemu-devel@nongnu.org; Mon, 12 Oct 2009 06:08:24 -0400
Date: Mon, 12 Oct 2009 12:08:21 +0200
From: Gleb Natapov <gleb@redhat.com>
Message-ID: <20091012100821.GE16702@redhat.com>
References: <1255287547-28329-1-git-send-email-gleb@redhat.com>
	<1255287547-28329-3-git-send-email-gleb@redhat.com>
	<20091011215356.GC6411@redhat.com>
	<20091012065024.GS16702@redhat.com>
	<20091012095225.GA11741@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20091012095225.GA11741@redhat.com>
Subject: [Qemu-devel] Re: [PATCH 3/5] Use the correct mask to size the PCI
 option ROM BAR.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: kevin@koconnor.net, qemu-devel@nongnu.org

On Mon, Oct 12, 2009 at 11:52:25AM +0200, Michael S. Tsirkin wrote:
> On Mon, Oct 12, 2009 at 08:50:24AM +0200, Gleb Natapov wrote:
> > Send patch with your favorite interpretation to qemu pcbios/seabios.
> > The regression concern from my previous mail applicable here as well.
> 
> Okay. Can you ack the following?
> 
I can if you'll add PCI spec reference for me to double check.
Also I prefer strict spec reading :)

> For ROM, bit 0 is the enable bit, which we not only don't want
> to set, but it will stick and make us think it's an I/O port
> resource. For I/O and memory BARs bit 0 is read-only, so
> it does not matter what we write there.
> 
> See Qemu pcbios commit 6ddb9f5c742b2b82b1755d7ec2a127f6e20e3806
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  src/pciinit.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/pciinit.c b/src/pciinit.c
> index eab082a..d315526 100644
> --- a/src/pciinit.c
> +++ b/src/pciinit.c
> @@ -137,7 +137,7 @@ static void pci_bios_init_device(u16 bdf)
>                  ofs = PCI_ROM_ADDRESS;
>              else
>                  ofs = PCI_BASE_ADDRESS_0 + i * 4;
> -            pci_config_writel(bdf, ofs, 0xffffffff);
> +            pci_config_writel(bdf, ofs, 0xfffffffe);
>              val = pci_config_readl(bdf, ofs);
>              if (val != 0) {
>                  size = (~(val & ~0xf)) + 1;
> -- 
> 1.6.5.rc2

--
			Gleb.