From: Adam Lackorzynski <adam@os.inf.tu-dresden.de>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] multiboot: Limit number of multiboot modules
Date: Mon, 12 Oct 2009 18:40:00 +0200 [thread overview]
Message-ID: <20091012164000.GK15282@os.inf.tu-dresden.de> (raw)
In-Reply-To: <4AD3085A.1050906@redhat.com>
On Mon Oct 12, 2009 at 12:43:38 +0200, Kevin Wolf wrote:
> Am 11.10.2009 15:48, schrieb adam@os.inf.tu-dresden.de:
> > From: Adam Lackorzynski <adam@os.inf.tu-dresden.de>
> >
> > Add size checks to avoid overwriting the multiboot structure
> > when too many modules are loaded.
> >
> > Signed-off-by: Adam Lackorzynski <adam@os.inf.tu-dresden.de>
>
> Acked-by: Kevin Wolf <kwolf@redhat.com>
>
> Looks correct, too, and is definitely an improvement over the current
> code. But can't we make it more dynamic in a second step? I don't like
> arbitrary fixed limits.
Yes, definitely. I'm looking into this.
Adam
--
Adam adam@os.inf.tu-dresden.de
Lackorzynski http://os.inf.tu-dresden.de/~adam/
next prev parent reply other threads:[~2009-10-12 16:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-11 13:48 [Qemu-devel] [PATCH 1/2] multiboot: Fix cmdline of modules adam
2009-10-11 13:48 ` [Qemu-devel] [PATCH 2/2] multiboot: Limit number of multiboot modules adam
2009-10-12 10:43 ` Kevin Wolf
2009-10-12 16:40 ` Adam Lackorzynski [this message]
2009-10-14 16:11 ` Adam Lackorzynski
2009-10-19 8:30 ` Kevin Wolf
2009-10-20 18:22 ` Adam Lackorzynski
[not found] ` <m3aazl8y4m.fsf@neno.mitica>
2009-10-21 9:29 ` [Qemu-devel] " Kevin Wolf
2009-10-12 10:28 ` [Qemu-devel] [PATCH 1/2] multiboot: Fix cmdline of modules Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091012164000.GK15282@os.inf.tu-dresden.de \
--to=adam@os.inf.tu-dresden.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).