From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1My3pe-00057J-JD
	for qemu-devel@nongnu.org; Wed, 14 Oct 2009 09:23:58 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1My3pZ-00055U-FG
	for qemu-devel@nongnu.org; Wed, 14 Oct 2009 09:23:57 -0400
Received: from [199.232.76.173] (port=53713 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1My3pX-00055L-Un
	for qemu-devel@nongnu.org; Wed, 14 Oct 2009 09:23:52 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42414)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lcapitulino@redhat.com>) id 1My3pX-00084v-I7
	for qemu-devel@nongnu.org; Wed, 14 Oct 2009 09:23:51 -0400
Date: Wed, 14 Oct 2009 10:23:40 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 08/10] monitor: Convert bdrv_info() to QObject
Message-ID: <20091014102340.7c3c071c@doriath>
In-Reply-To: <87bpkf1lz8.fsf@pike.pond.sub.org>
References: <1255037747-3340-1-git-send-email-lcapitulino@redhat.com>
	<1255037747-3340-9-git-send-email-lcapitulino@redhat.com>
	<87bpkf1lz8.fsf@pike.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

On Sat, 10 Oct 2009 14:18:03 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Luiz Capitulino <lcapitulino@redhat.com> writes:
> 
> > Each block device information is stored in a QDict and the
> > returned QObject is a QList of all devices.
> >
> > The QDict contains the following:
> >
> > - "device": device name
> > - "type": device type
> > - "removable": 1 if the device is removable 0 otherwise
> > - "locked": 1 if the device is locked 0 otherwise
> > - "backing_file": backing file name if one is used
> 
> Isn't this in "interted" rather than here?
> 
> If yes, the comment in the code needs fixing, too.

 Yes, although I don't think I should resend just because of that.