From: Aurelien Jarno <aurelien@aurel32.net>
To: Roy Tam <roytam@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] mips64el: fix: Tried to create isa device mc146818rtc with no isa bus present
Date: Thu, 15 Oct 2009 11:46:22 +0200 [thread overview]
Message-ID: <20091015094622.GA18638@volta.aurel32.net> (raw)
In-Reply-To: <473191350910132348y7e9b9738wdf591b0589a9e86a@mail.gmail.com>
On Wed, Oct 14, 2009 at 02:48:21PM +0800, Roy Tam wrote:
> As i8259 in mips_jazz.c is not connect to isa bus correctly, this
> patch fix that.
It looks fine. Could you please resend the patch with a Signed-off-by:
> diff --git a/hw/mips_jazz.c b/hw/mips_jazz.c
> index 3ff367d..281713c 100644
> --- a/hw/mips_jazz.c
> +++ b/hw/mips_jazz.c
> @@ -185,6 +185,8 @@ void mips_jazz_init (ram_addr_t ram_size,
>
> /* ISA devices */
> i8259 = i8259_init(env->irq[4]);
> + isa_bus_new(NULL);
> + isa_bus_irqs(i8259);
> DMA_init(0);
> pit = pit_init(0x40, i8259[0]);
> pcspk_init(pit);
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
next prev parent reply other threads:[~2009-10-15 9:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-14 6:48 [Qemu-devel] [PATCH] mips64el: fix: Tried to create isa device mc146818rtc with no isa bus present Roy Tam
2009-10-15 9:46 ` Aurelien Jarno [this message]
2009-10-15 14:07 ` Roy Tam
2009-10-15 14:10 ` Roy Tam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091015094622.GA18638@volta.aurel32.net \
--to=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
--cc=roytam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).